Skip to content

fix: set popupType to Window for launchpad menus to avoid clipping - #817

Open
mhduiy wants to merge 1 commit into
masterfrom
agent/pms-bug-bot/311f25c6b76e
Open

mhduiy wants to merge 1 commit into
masterfrom
agent/pms-bug-bot/311f25c6b76e

Conversation

@mhduiy

@mhduiy mhduiy commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

fix: set popupType to Window for launchpad menus to avoid clipping

BUG-280627

Add popupType: Popup.Window to the three Menu instances in dde-launchpad
(AppItemMenu.qml, DummyAppItemMenu.qml, SideBar.qml) so that context menus
render as independent top-level windows instead of in-item overlays, fixing
the issue where menus are clipped by the launcher window boundary.

This change is scoped to dde-launchpad only and does not modify shared
dtkdeclarative components, avoiding risk to other DTK applications.

Summary by Sourcery

Bug Fixes:

  • Prevent launchpad context menus from being clipped by the launcher window boundary.

BUG-280627

Add popupType: Popup.Window to the three Menu instances in dde-launchpad
(AppItemMenu.qml, DummyAppItemMenu.qml, SideBar.qml) so that context menus
render as independent top-level windows instead of in-item overlays, fixing
the issue where menus are clipped by the launcher window boundary.

This change is scoped to dde-launchpad only and does not modify shared
dtkdeclarative components, avoiding risk to other DTK applications.
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR fixes clipped launchpad context menus by setting popupType: Popup.Window on the three dde-launchpad menu instances, keeping the change localized to launchpad QML rather than shared DTK components.

File-Level Changes

Change Details Files
Configure launchpad menus as independent window popups to prevent clipping at the launcher boundary.
  • Set popupType to Popup.Window on the app-item context menu.
  • Apply the same popup behavior to the dummy app-item menu.
  • Apply the same popup behavior to the windowed sidebar categorized menu.
qml/AppItemMenu.qml
qml/DummyAppItemMenu.qml
qml/windowed/SideBar.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 总体评分 100 分,大于 70 分通过阈值。本次变更在三个 QML 文件中为 Menu 组件添加 popupType: Popup.Window 属性,修复了启动器菜单被窗口边界裁剪的问题。变更范围小、目的明确、实现正确,未发现安全漏洞或质量问题。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 语法正确,逻辑清晰,无需修改


2. 代码质量 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 代码结构清晰,变更一致性好,无需修改


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 性能良好,资源使用合理,无需修改


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞
漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个

安全漏洞详情:
✅ 未发现安全漏洞

建议: 存在0个安全漏洞,安全合规,无需修改


💡 改进建议代码示例

// 本次变更已为正确实现,无需修改
// 三个文件均已正确添加 popupType: Popup.Window
//
// qml/AppItemMenu.qml:
// Menu {
//     id: contextMenu
//     objectName: "ContextMenu"
//     popupType: Popup.Window  // 新增:以独立窗口方式渲染,避免被裁剪
// }
//
// qml/DummyAppItemMenu.qml:
// Menu {
//     id: contextMenu
//     objectName: "ContextMenu_2"
//     popupType: Popup.Window  // 新增:以独立窗口方式渲染,避免被裁剪
// }
//
// qml/windowed/SideBar.qml:
// D.Menu {
//     id: categorizedMenu
//     objectName: "CategorizedMenu"
//     popupType: Popup.Window  // 新增:以独立窗口方式渲染,避免被裁剪
// }

本报告由 AI 代码审查工具自动生成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants