Conversation
BUG-280627 Add popupType: Popup.Window to the three Menu instances in dde-launchpad (AppItemMenu.qml, DummyAppItemMenu.qml, SideBar.qml) so that context menus render as independent top-level windows instead of in-item overlays, fixing the issue where menus are clipped by the launcher window boundary. This change is scoped to dde-launchpad only and does not modify shared dtkdeclarative components, avoiding risk to other DTK applications.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR fixes clipped launchpad context menus by setting File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: 语法正确,逻辑清晰,无需修改 2. 代码质量 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: 代码结构清晰,变更一致性好,无需修改 3. 代码性能 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: 性能良好,资源使用合理,无需修改 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: 存在0个安全漏洞,安全合规,无需修改 💡 改进建议代码示例// 本次变更已为正确实现,无需修改
// 三个文件均已正确添加 popupType: Popup.Window
//
// qml/AppItemMenu.qml:
// Menu {
// id: contextMenu
// objectName: "ContextMenu"
// popupType: Popup.Window // 新增:以独立窗口方式渲染,避免被裁剪
// }
//
// qml/DummyAppItemMenu.qml:
// Menu {
// id: contextMenu
// objectName: "ContextMenu_2"
// popupType: Popup.Window // 新增:以独立窗口方式渲染,避免被裁剪
// }
//
// qml/windowed/SideBar.qml:
// D.Menu {
// id: categorizedMenu
// objectName: "CategorizedMenu"
// popupType: Popup.Window // 新增:以独立窗口方式渲染,避免被裁剪
// }本报告由 AI 代码审查工具自动生成 |
fix: set popupType to Window for launchpad menus to avoid clipping
BUG-280627
Add popupType: Popup.Window to the three Menu instances in dde-launchpad
(AppItemMenu.qml, DummyAppItemMenu.qml, SideBar.qml) so that context menus
render as independent top-level windows instead of in-item overlays, fixing
the issue where menus are clipped by the launcher window boundary.
This change is scoped to dde-launchpad only and does not modify shared
dtkdeclarative components, avoiding risk to other DTK applications.
Summary by Sourcery
Bug Fixes: