Skip to content

[feat] add support for deleting reserved IPv4 addresses in NodeBalancer deletion#589

Open
moshevayner wants to merge 3 commits into
mainfrom
release-reserved-ip-support
Open

[feat] add support for deleting reserved IPv4 addresses in NodeBalancer deletion#589
moshevayner wants to merge 3 commits into
mainfrom
release-reserved-ip-support

Conversation

@moshevayner

Copy link
Copy Markdown
Member

Default behavior is still to retain the reserved IP, just to maintain backwards compatibility

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

…er deletion

Default behavior is still to retain the reserved IP, just to maintain backwards compatibility

Signed-off-by: Moshe Vayner <moshe@vayner.me>
@github-actions github-actions Bot added the new-feature for new features in the changelog. label Jul 10, 2026
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.76%. Comparing base (512ca7e) to head (b15eb93).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   73.68%   73.76%   +0.07%     
==========================================
  Files          19       19              
  Lines        3036     3045       +9     
==========================================
+ Hits         2237     2246       +9     
  Misses        538      538              
  Partials      261      261              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Moshe Vayner <moshe@vayner.me>
…balancer

Signed-off-by: Moshe Vayner <moshe@vayner.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant