[feat] add support for deleting reserved IPv4 addresses in NodeBalancer deletion#589
Open
moshevayner wants to merge 3 commits into
Open
[feat] add support for deleting reserved IPv4 addresses in NodeBalancer deletion#589moshevayner wants to merge 3 commits into
moshevayner wants to merge 3 commits into
Conversation
…er deletion Default behavior is still to retain the reserved IP, just to maintain backwards compatibility Signed-off-by: Moshe Vayner <moshe@vayner.me>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 73.68% 73.76% +0.07%
==========================================
Files 19 19
Lines 3036 3045 +9
==========================================
+ Hits 2237 2246 +9
Misses 538 538
Partials 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
13ad7f7 to
d581d1d
Compare
Signed-off-by: Moshe Vayner <moshe@vayner.me>
d581d1d to
f54b348
Compare
…balancer Signed-off-by: Moshe Vayner <moshe@vayner.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default behavior is still to retain the reserved IP, just to maintain backwards compatibility
General:
Pull Request Guidelines: