Skip to content

[improvement] set log level for node_controller to higher level than default to reduce spam#587

Merged
AshleyDumaine merged 1 commit into
mainfrom
reduce-log-spam
Jul 7, 2026
Merged

[improvement] set log level for node_controller to higher level than default to reduce spam#587
AshleyDumaine merged 1 commit into
mainfrom
reduce-log-spam

Conversation

@AshleyDumaine

Copy link
Copy Markdown
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Changes

Node controller prints a log message every time a node updates. On large clusters, this creates a spam that makes reading logs difficult and consumes storage space unnecessarily.
By default, the CCM logs at level 3. Since these are more of a debugging message, I've explicitly set the level of them to 4.

@github-actions github-actions Bot added the improvement for improvements in existing functionality in the changelog. label Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.65%. Comparing base (916513b) to head (d954499).

Files with missing lines Patch % Lines
cloud/linode/node_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          19       19           
  Lines        3029     3029           
=======================================
  Hits         2231     2231           
  Misses        538      538           
  Partials      260      260           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine AshleyDumaine enabled auto-merge (squash) July 7, 2026 18:41
@AshleyDumaine AshleyDumaine merged commit 8ea345d into main Jul 7, 2026
10 of 12 checks passed
@AshleyDumaine AshleyDumaine deleted the reduce-log-spam branch July 7, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants