[deps] bump linodego to v2#585
Merged
Merged
Conversation
0bc3773 to
17e7a2d
Compare
17e7a2d to
713f128
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
==========================================
+ Coverage 73.65% 73.68% +0.02%
==========================================
Files 19 19
Lines 3029 3036 +7
==========================================
+ Hits 2231 2237 +6
Misses 538 538
- Partials 260 261 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Linode API client dependency from github.com/linode/linodego v1 to github.com/linode/linodego/v2, updating the cloud controller manager’s Linode integrations (NodeBalancer, firewall, VPC routes, instance metadata, and Cilium shared-IP support) to match linodego v2’s API and type changes.
Changes:
- Switch all linodego imports to
github.com/linode/linodego/v2and bump the module requirement. - Update code and tests for linodego v2 API/type changes (e.g., instance IPv4 representation, firewall rule types, NodeBalancer VPC options,
NewClientreturning an error,AddInstanceIPAddressoptions). - Refresh
go.mod/go.sumto reflect transitive dependency changes from the upgrade.
Reviewed changes
Copilot reviewed 25 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| main.go | Updates linodego import path to v2. |
| go.mod | Bumps linodego dependency to v2 and adjusts indirect deps/replace directives. |
| go.sum | Updates checksums to match the dependency graph after the bump. |
| cloud/nodeipam/ipam/cloud_allocator.go | Updates linodego import path to v2. |
| cloud/nodeipam/ipam/cloud_allocator_test.go | Updates linodego import path to v2 in tests. |
| cloud/linode/utils/common.go | Updates linodego import path and adapts IsPrivate signature/behavior for v2-related type usage. |
| cloud/linode/utils/common_test.go | Updates linodego import path to v2 in tests. |
| cloud/linode/services/vpc.go | Updates linodego import path to v2. |
| cloud/linode/services/vpc_test.go | Updates linodego import path to v2 in tests. |
| cloud/linode/services/instances.go | Updates linodego import path to v2 (and aligns with v2 instance IP handling). |
| cloud/linode/services/instances_test.go | Updates tests for v2 instance IPv4 representation changes. |
| cloud/linode/services/firewalls.go | Updates firewall rule types/options to linodego v2 shapes. |
| cloud/linode/services/firewalls_test.go | Updates firewall-related tests to v2 rule types/options. |
| cloud/linode/service_controller.go | Updates linodego import path to v2. |
| cloud/linode/route_controller.go | Updates v2 interface update option shapes (ranges/IPRanges). |
| cloud/linode/route_controller_test.go | Updates tests/import ordering for v2 and instance IPv4 changes. |
| cloud/linode/node_controller.go | Updates linodego import path to v2 (and aligns with v2 instance IP handling). |
| cloud/linode/node_controller_test.go | Updates tests for v2 instance IPv4 representation changes. |
| cloud/linode/loadbalancers.go | Updates NodeBalancer create/update options and VPC config fields for v2. |
| cloud/linode/loadbalancers_test.go | Updates tests for v2 client creation, firewall rules, and NodeBalancer VPC fields/types. |
| cloud/linode/loadbalancers_helpers.go | Updates linodego import path to v2. |
| cloud/linode/health_check_test.go | Updates linodego import path to v2 in tests. |
| cloud/linode/fake_linode_test.go | Updates fake API types/handlers to match v2 firewall/nodebalancer update payloads. |
| cloud/linode/client/mocks/mock_client.go | Updates generated mock signatures for v2 API changes. |
| cloud/linode/client/client.go | Updates client construction for v2 (NewClient error) and API signature changes. |
| cloud/linode/client/client_with_metrics.go | Updates metrics decorator signatures/return types for v2 APIs. |
| cloud/linode/cilium_loadbalancers.go | Updates AddInstanceIPAddress call to v2 options struct. |
| cloud/linode/cilium_loadbalancers_test.go | Updates Cilium shared-IP tests for v2 types and AddInstanceIPAddress options. |
Files not reviewed (2)
- cloud/linode/client/client_with_metrics.go: Generated file
- cloud/linode/client/mocks/mock_client.go: Generated file
1199495 to
6e1299a
Compare
6e1299a to
a6e4dcb
Compare
komer3
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General:
Pull Request Guidelines:
linodego v1 is not receiving backports for features going into the new v2 (which has been out for a month).
See https://github.com/linode/linodego/blob/main/docs/linode_v2_migration_guide.md