Skip to content

[deps] bump linodego to v2#585

Merged
AshleyDumaine merged 2 commits into
mainfrom
linodego-v2
Jul 8, 2026
Merged

[deps] bump linodego to v2#585
AshleyDumaine merged 2 commits into
mainfrom
linodego-v2

Conversation

@AshleyDumaine

@AshleyDumaine AshleyDumaine commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

linodego v1 is not receiving backports for features going into the new v2 (which has been out for a month).
See https://github.com/linode/linodego/blob/main/docs/linode_v2_migration_guide.md

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.68%. Comparing base (8ea345d) to head (a6e4dcb).

Files with missing lines Patch % Lines
cloud/linode/client/client.go 60.00% 1 Missing and 1 partial ⚠️
cloud/linode/loadbalancers.go 93.33% 1 Missing ⚠️
cloud/linode/services/firewalls.go 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   73.65%   73.68%   +0.02%     
==========================================
  Files          19       19              
  Lines        3029     3036       +7     
==========================================
+ Hits         2231     2237       +6     
  Misses        538      538              
- Partials      260      261       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine AshleyDumaine marked this pull request as ready for review July 6, 2026 16:42
@AshleyDumaine AshleyDumaine changed the title [breaking][deps] bump linodego to v2 [deps] bump linodego to v2 Jul 6, 2026
@AshleyDumaine AshleyDumaine requested a review from Copilot July 6, 2026 17:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Linode API client dependency from github.com/linode/linodego v1 to github.com/linode/linodego/v2, updating the cloud controller manager’s Linode integrations (NodeBalancer, firewall, VPC routes, instance metadata, and Cilium shared-IP support) to match linodego v2’s API and type changes.

Changes:

  • Switch all linodego imports to github.com/linode/linodego/v2 and bump the module requirement.
  • Update code and tests for linodego v2 API/type changes (e.g., instance IPv4 representation, firewall rule types, NodeBalancer VPC options, NewClient returning an error, AddInstanceIPAddress options).
  • Refresh go.mod/go.sum to reflect transitive dependency changes from the upgrade.

Reviewed changes

Copilot reviewed 25 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
main.go Updates linodego import path to v2.
go.mod Bumps linodego dependency to v2 and adjusts indirect deps/replace directives.
go.sum Updates checksums to match the dependency graph after the bump.
cloud/nodeipam/ipam/cloud_allocator.go Updates linodego import path to v2.
cloud/nodeipam/ipam/cloud_allocator_test.go Updates linodego import path to v2 in tests.
cloud/linode/utils/common.go Updates linodego import path and adapts IsPrivate signature/behavior for v2-related type usage.
cloud/linode/utils/common_test.go Updates linodego import path to v2 in tests.
cloud/linode/services/vpc.go Updates linodego import path to v2.
cloud/linode/services/vpc_test.go Updates linodego import path to v2 in tests.
cloud/linode/services/instances.go Updates linodego import path to v2 (and aligns with v2 instance IP handling).
cloud/linode/services/instances_test.go Updates tests for v2 instance IPv4 representation changes.
cloud/linode/services/firewalls.go Updates firewall rule types/options to linodego v2 shapes.
cloud/linode/services/firewalls_test.go Updates firewall-related tests to v2 rule types/options.
cloud/linode/service_controller.go Updates linodego import path to v2.
cloud/linode/route_controller.go Updates v2 interface update option shapes (ranges/IPRanges).
cloud/linode/route_controller_test.go Updates tests/import ordering for v2 and instance IPv4 changes.
cloud/linode/node_controller.go Updates linodego import path to v2 (and aligns with v2 instance IP handling).
cloud/linode/node_controller_test.go Updates tests for v2 instance IPv4 representation changes.
cloud/linode/loadbalancers.go Updates NodeBalancer create/update options and VPC config fields for v2.
cloud/linode/loadbalancers_test.go Updates tests for v2 client creation, firewall rules, and NodeBalancer VPC fields/types.
cloud/linode/loadbalancers_helpers.go Updates linodego import path to v2.
cloud/linode/health_check_test.go Updates linodego import path to v2 in tests.
cloud/linode/fake_linode_test.go Updates fake API types/handlers to match v2 firewall/nodebalancer update payloads.
cloud/linode/client/mocks/mock_client.go Updates generated mock signatures for v2 API changes.
cloud/linode/client/client.go Updates client construction for v2 (NewClient error) and API signature changes.
cloud/linode/client/client_with_metrics.go Updates metrics decorator signatures/return types for v2 APIs.
cloud/linode/cilium_loadbalancers.go Updates AddInstanceIPAddress call to v2 options struct.
cloud/linode/cilium_loadbalancers_test.go Updates Cilium shared-IP tests for v2 types and AddInstanceIPAddress options.
Files not reviewed (2)
  • cloud/linode/client/client_with_metrics.go: Generated file
  • cloud/linode/client/mocks/mock_client.go: Generated file

Comment thread go.mod
@AshleyDumaine AshleyDumaine removed the breaking-change for breaking changes in the changelog. label Jul 6, 2026
@AshleyDumaine AshleyDumaine merged commit 512ca7e into main Jul 8, 2026
13 of 15 checks passed
@AshleyDumaine AshleyDumaine deleted the linodego-v2 branch July 8, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies dependency updates including security fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants