Repository navigation
Add ShakeDelegate.shouldHandleShake() to gate shakes per event - #102
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
alecramirez
approved these changes
Oct 14, 2026
alecramirez
approved these changes
Oct 14, 2026
kkoser
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ShakeDelegate.shouldHandleShake()(defaulttrue) and checks it at the top ofShaky.hearShake(), before the custom-handling check,onShakyStarted, screenshot capture and data collection. An ignored shake is logged.Why:
ShakeDelegate.isEnabled()is only evaluated when an activity resumes and the shake sensor is registered, so apps can't honor a setting that changes afterwards. This lets an app customize the behavior per shake. Apps that don't override it are unaffected.startFeedbackFlow()) are unchanged.Testing
./gradlew clean check: passedShakyShould: default istrue; a declined shake is ignored (no callback) with and without custom handling, and without checking custom handling; the flow starts when the delegate accepts.