Repository navigation
Backport rewrite delete file fix (#10020) to iceberg 1.5 - #277
Conversation
|
what version are we backporting from? |
|
Its unclear from your commits what is backported vs fix forward. I might backport and commit merge conflicts, then update forward with new commits. |
946c353 to
ee05306
Compare
1.6.0 |
Currently there are 2 commits. First for backport. Second for fix forward. |
| } else { | ||
| newFields.add(Types.NestedField.required(newIds.get(i), field.name(), type, field.doc())); | ||
| } | ||
| newFields.add(Types.NestedField.from(field).withId(newIds.get(i)).ofType(type).build()); |
There was a problem hiding this comment.
Is there no more differentiation or is it implicit with the from?
There was a problem hiding this comment.
from() will copy everything from the old field. This is a new method added by @cbb330 to support default values.
A +1 response to this comment to indicate it actually was clean I'll take vs redoing. |
…th more than 1k columns (#10020) (cherry picked from commit b6c949c) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adapt field ID reassignment to preserve initial and write defaults, add regression coverage, and accept the expected metadata schema serialization changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ee05306 to
e970429
Compare
I just used |
Summary
Backport the fix from iceberg #10020. This is needed because we ran into the same issue in production.
Testing Done
gradle build.