Skip to content

Try to connect to any zookeeper, even if first one is dead/unavailable #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
proggga wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Try to connect to any zookeeper, even if first one is dead/unavailable #824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions core/internal/helpers/zookeeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ package helpers
import (
"crypto/tls"
"crypto/x509"
stderrors "errors"
"net"
"os"
"time"
Expand Down Expand Up @@ -57,9 +58,24 @@ func ZookeeperConnectTLS(servers []string, sessionTimeout time.Duration, logger

logger.Info("starting zookeeper (TLS)", zap.String("caFile", caFile), zap.String("certFile", certFile), zap.String("keyFile", keyFile))

dialer, err := newTLSDialer(servers[0], caFile, certFile, keyFile)
if err != nil {
return nil, nil, err
var dialer zk.Dialer = nil
var connectivityErrors error

for _, server := range servers {
var err error
dialer, err = newTLSDialer(server, caFile, certFile, keyFile)
if err != nil {
logger.Error("failed to create TLS dialer to server", zap.String("server", server), zap.Error(err))
connectivityErrors = stderrors.Join(connectivityErrors, err)
} else {
// we found a working server, so we can stop looking
logger.Info("created TLS dialer to server", zap.String("server", server))
break
}
}

if dialer == nil {
return nil, nil, connectivityErrors
}

// We need a function to set the logger for the ZK connection
Expand Down