Skip to content

docs(changelog): record 1.1.4, and version the frontend enqueues - #17

Merged
eleshar merged 1 commit into
masterfrom
docs/changelog-1.1.4
Sep 8, 2026
Merged

eleshar merged 1 commit into
masterfrom
docs/changelog-1.1.4

Conversation

@eleshar

@eleshar eleshar commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Adds the 1.1.4 changelog entry for the gulp to terser and WP-CLI migration and
the two Dependabot alerts it cleared, in the format this changelog uses.

Version

Bumps the plugin header, LSX_TO_MAPS_VER and package.json to 1.1.4. The
header and constant were already ahead of package.json (1.1.3 against
1.1.1); all three now agree.

Cache busting, worth a look

Both frontend scripts were enqueued with null as the version argument, so
WordPress emitted no query string at all:

wp_enqueue_script( 'lsx_to_maps', ... , null, true );

The rebuilt to-maps.min.js could therefore have been served stale
indefinitely from browser and CDN caches. They now version off
LSX_TO_MAPS_VER, which is what the bump exists for. The Google Maps API
script keeps null, since it is a remote URL we do not version.

Verification

  • php -l clean across all tracked PHP.
  • Semgrep (p/security-audit, p/secrets, p/php): 0 findings.

Adds the 1.1.4 entry covering the gulp to terser/WP-CLI migration and the
two Dependabot alerts it cleared, in the format this changelog uses.

Bumps the plugin header, LSX_TO_MAPS_VER and package.json to 1.1.4. The
header and constant were already ahead of package.json at 1.1.3 against
1.1.1; all three now agree.

Also fixes the cache bust. Both frontend scripts were enqueued with a null
version argument, so WordPress emitted no query string and the rebuilt
to-maps.min.js could have been served stale indefinitely. They now version
off LSX_TO_MAPS_VER, which is what the bump is for.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4aafe2dd-eff5-48cb-861e-d0b6830da677

📥 Commits

Reviewing files that changed from the base of the PR and between c913a6f and 0c3a485.

📒 Files selected for processing (4)
  • changelog.txt
  • classes/class-to-maps-frontend.php
  • package.json
  • to-maps.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eleshar
eleshar merged commit 5f94b70 into master Sep 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant