Add --insecure option to allow forcing unencrypted http#115
Open
ljelinek-cznic wants to merge 1 commit intolibrespeed:masterfrom
Open
Add --insecure option to allow forcing unencrypted http#115ljelinek-cznic wants to merge 1 commit intolibrespeed:masterfrom
ljelinek-cznic wants to merge 1 commit intolibrespeed:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a reaction to the change of the server list (see librespeed/speedtest#772). Because some devices cannot work correctly via https (CPU overload leads to very incorrect measurement results), I suggest to introduce a new command line option. It will allow forcing unencrypted http (and override schemes contained in the server list).
The new
--insecureoption is very similar to the--secureone, but it it inverse. If it is present, the (unencrypted) http schema is forced. If both--secureand--insecureoptions are present,--securetakes precedence.