Skip to content

normalize_bpf_test_names: don't drop tests that share a name prefix #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theihor merged 1 commit into from
Aug 11, 2026
Merged

normalize_bpf_test_names: don't drop tests that share a name prefix #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion run-vmtest/normalize_bpf_test_names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ def next_test(lines: list[str]):
prev = lines[0]

def is_subtest(line: str) -> bool:
return ('/' in line) and ('/' not in prev) and line.startswith(prev)
# Compare against "prev/" rather than "prev": without the separator
# "a_test" also swallows "a_test_two/subtest", which is a subtest of a
# different test that happens to share a prefix.
return ('/' not in prev) and line.startswith(prev + '/')

yield lines[0]
for line in lines[1:]:
Expand Down
2 changes: 2 additions & 0 deletions run-vmtest/tests/normalize_bpf_test_names/expected-output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ test4_blah
test5
test6
test7/subtest123
test8
test8_peek/subtest1
2 changes: 2 additions & 0 deletions run-vmtest/tests/normalize_bpf_test_names/input.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ test5 # should consume test5/s
## some blank lines, should be removed


test8
test8_peek/subtest1 # must be kept: test8_peek is a different test, not a subtest of test8
Loading