Fix not found error for md5#6037
Merged
rtibbles merged 1 commit intoJul 11, 2026
Merged
Conversation
…objects The resumable upload_url path calls get_stored_object_md5(filepath) to dedup against a stored object's md5. On CompositeGCS this delegated to _get_readable_backend(name), which raises FileNotFoundError when the object is in no backend -- i.e. every not-yet-uploaded file -- 500ing upload_url for all new resumable uploads. Catch FileNotFoundError and return None, matching GoogleCloudStorage.get_stored_object_md5 for a missing blob. Add regression tests for the found and not-found cases; the not-found test fails against the pre-fix code (FileNotFoundError). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ineqU2EGLAcWW2WPWR3mE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes FileNotFoundError when trying to get the md5 for a file that doesn't exist in GCS
References
Clean up from #5995
AI usage
Had Claude quickly trace this from the log output in hotfixes