Repository navigation
perf: make Except.bind and OptionT.bind abbreviations for lazy-delta reduction - #16336
Open
arthur-adjedj wants to merge 1 commit into
Open
arthur-adjedj wants to merge 1 commit into
arthur-adjedj wants to merge 1 commit into
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for a838dab against d4cada4 are in. There are significant results. @arthur-adjedj
Large changes (40✅)
Medium changes (7✅, 2🟥)
Small changes (16✅, 9🟥)
|
arthur-adjedj
marked this pull request as ready for review
November 7, 2026 13:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids
Except.bindandOptionT.bindfrom always reducing their continuations during definitional equality. This reduction can quickly become expensive, despite often not being useful. This performance regression is avoided by making these declarations be marked as abbreviations for lazy-delta reduction. Comparing #15447'smwe.leanexample shows a measurable performance gain:Closes #15447