fix: contain sandbox descendants with util-linux - #78
Open
kim-em wants to merge 2 commits into
Open
Conversation
kim-em
force-pushed
the
fix/descendant-cleanup
branch
from
August 20, 2026 05:45
7dff5cf to
bae26be
Compare
kim-em
force-pushed
the
fix/descendant-cleanup
branch
from
August 20, 2026 05:49
bae26be to
059f494
Compare
kim-em
force-pushed
the
fail-closed-option
branch
from
August 20, 2026 06:21
186f188 to
e950087
Compare
kim-em
force-pushed
the
fix/descendant-cleanup
branch
2 times, most recently
from
August 20, 2026 07:29
443870b to
60066c6
Compare
kim-em
force-pushed
the
fail-closed-option
branch
from
August 20, 2026 12:55
e730d1a to
4534d81
Compare
kim-em
force-pushed
the
fix/descendant-cleanup
branch
from
August 20, 2026 12:55
60066c6 to
8f6f285
Compare
kim-em
changed the title
kim-em
force-pushed
the
fail-closed-option
branch
from
August 20, 2026 13:34
4534d81 to
5846789
Compare
kim-em
force-pushed
the
fix/descendant-cleanup
branch
from
August 20, 2026 13:34
8f6f285 to
14b5039
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains each sandboxed command in a fresh user, PID, and mount namespace when the host supports unprivileged namespaces, ensuring that processes left behind by the command are killed before Comparator continues.
Comparator preflights the exact
setprivandunsharesupervisor before starting any workload. A successful preflight is used for every workload Landrun invocation, including external kernels. Withfail_closed: true, setup failure produces an actionable error and no workload starts. Withfail_closed: false, Comparator warns once and runs Landrun without descendant containment. It never retries a workload command.The error reports the setup diagnostic and relevant util-linux, sysctl, and container guidance. The CI workflow configures the required user-namespace settings on
ubuntu-latestbefore running the test suite.Tests cover namespace setup failure, strict and compatibility behavior, and cleanup of a detached
setsiddescendant.Closes #77.