Repository navigation
feat: add automorphisms of the infinite regular rooted tree - #46052
EzequielS2 wants to merge 5 commits into
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to Zulip and join the Lean community. |
PR summary c17e4f46a9Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| 472 | 13 | backward.privateInPublic |
| 188 | 11 | backward.privateInPublic.warn |
Increase in weak tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type (weak) |
|---|---|---|
| 5153 | 1 | exposed public sections |
Current commit c17e4f46a9
Reference commit a906e4e0c0
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
These commands made the changes in this commit. To make the same fixes yourself, run them in your mathlib4 checkout.
|
-awaiting-author |
| @[expose] public section | ||
|
|
||
| /-- The infinite regular rooted tree on the alphabet `α`: vertices are finite words. -/ | ||
| abbrev InfiniteRegularTree (α : Type*) := List α |
There was a problem hiding this comment.
I wonder if this should be a one-field structure rather than an abbrev? For instance, right now if you use ext on TreeAut, it will go straight through and use the ext lemma for lists which is quite undesirable.
There was a problem hiding this comment.
(maybe that would make the rest of the file too painful)
There was a problem hiding this comment.
(there's also the option of def rather than abbrev)
There was a problem hiding this comment.
Kept as an abbrev, same pattern as OrderIso and SimpleGraph.Iso. I tried a one-field structure and a def: the structure needs extra FunLike/Group boilerplate, and with FunLike the ext tactic still continues into List.ext_getElem?. A def loses the inherited FunLike/Group instances from RelIso. So abbrev seems the best fit here, and we use RelIso.ext explicitly when proving equalities..
There was a problem hiding this comment.
On the contrary, I think we should get rid of this alias and use List directly.
| l₁.Nodup := | ||
| hn.sublist h.sublist | ||
|
|
||
| /-- A proper prefix is strictly shorter. -/ |
There was a problem hiding this comment.
| /-- A proper prefix is strictly shorter. -/ |
| @[expose] public section | ||
|
|
||
| /-- The infinite regular rooted tree on the alphabet `α`: vertices are finite words. -/ | ||
| abbrev InfiniteRegularTree (α : Type*) := List α |
There was a problem hiding this comment.
On the contrary, I think we should get rid of this alias and use List directly.
Add InfiniteRegularTree n and the root decomposition of TreeAut n.