Repository navigation
Conversation
vihdzp
commented
Nov 3, 2026
PR summary 4a6d8f7295
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Order.Bounds.Basic | 335 | 339 | +4 (+1.19%) |
Import changes for all files
| Files | Import difference |
|---|---|
4 filesMathlib.Algebra.Order.GroupWithZero.Bounds Mathlib.Order.Interval.Set.Fin Mathlib.Order.Interval.Set.OrderEmbedding Mathlib.Order.Interval.Set.UnorderedInterval |
1 |
Mathlib.Order.Bounds.Image Mathlib.Order.ScottContinuity |
3 |
8 filesMathlib.Algebra.Order.Group.Bounds Mathlib.Data.Nat.Prime.Infinite Mathlib.Order.Bounds.Basic Mathlib.Order.CompleteLattice.Defs Mathlib.Order.ConditionallyCompletePartialOrder.Basic Mathlib.Order.LatticeIntervals Mathlib.Order.Monotone.Odd Mathlib.Order.Monotone.Union |
4 |
Declarations diff (regex)
+ DirSupClosed.of_wellFoundedGT
+ DirSupClosedOn.of_wellFoundedGT
+ DirSupInacc.of_wellFoundedGT
+ DirSupInaccOn.of_wellFoundedGT
+ IsGLB.isLeast_of_wellFoundedLT
+ IsGLB.mem_of_wellFoundedLT
+ IsGLB.min_eq
+ WellFoundedLT.isLeast_min
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean -- stale, waiting for the new build)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
a09757e).
- +8 new declarations
- −0 removed declarations
+DirSupClosed.of_wellFoundedGT
+DirSupClosedOn.of_wellFoundedGT
+DirSupInacc.of_wellFoundedGT
+DirSupInaccOn.of_wellFoundedGT
+IsGLB.mem_of_nonempty
+IsGLB.min_eq
+IsLUB.max_eq
+IsLUB.mem_of_nonemptyNo changes to strong technical debt.
No changes to weak technical debt.
Current commit 4a6d8f7295
Reference commit a495318fed
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
SnirBroshi
left a comment
There was a problem hiding this comment.
You might be interested in SnirBroshi#97 :)
There was a problem hiding this comment.
I'm pretty sure these are true for any PartialOrder, not just for LinearOrders
There was a problem hiding this comment.
Do you have a proof? I'm having a hard time figuring it out. (Does every nonempty directed set in a WellFoundedGT order have a maximum? Do we have that somewhere?)
There was a problem hiding this comment.
theorem DirSupClosed.of_notMem_imp_isCompactElement {α : Type*} [PartialOrder α] {s : Set α}
(h : ∀ a ∉ s, IsCompactElement a) : DirSupClosed s := by
intro d hsub hne hdir a hlub
by_contra hmem
have ⟨b, hmem', hle⟩ := h a hmem d a hne hdir hlub le_rfl
cases hle.antisymm <| hlub.left hmem'
exact hmem <| hsub hmem'
theorem DirSupInacc.of_mem_imp_isCompactElement {α : Type*} [PartialOrder α] {s : Set α}
(h : ∀ a ∈ s, IsCompactElement a) : DirSupInacc s :=
.of_compl <| .of_notMem_imp_isCompactElement <| by simpa
example {α : Type*} [PartialOrder α] [WellFoundedGT α] (s : Set α) : DirSupClosed s :=
.of_notMem_imp_isCompactElement fun a _ ↦ .of_wellFoundedGT a
example {α : Type*} [PartialOrder α] [WellFoundedGT α] (s : Set α) : DirSupInacc s :=
.of_mem_imp_isCompactElement fun a _ ↦ .of_wellFoundedGT aDoes every nonempty directed set in a
WellFoundedGTorder have a maximum? Do we have that somewhere?
Yes, no. You could combine DirectedOn.maximal_iff_isGreatest with WellFoundedGT.exists_maximal or WellFounded.maximal_wellFounded_lt_max to get it.
There was a problem hiding this comment.
Well, it seems we want to use IsCompactElement to prove things about DirSupClosed and also the other way around. Perhaps we should move the former to the DirSupClosed.lean file when we redefine it?