You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(Algebra/Homology/HomologicalComplex): use to_dual - #44672
This PR uses to_dual on HomologicalComplex, making ChainComplex dual to CochainComplex.
The type of CochainComplex.ofHom and CochainComplex.mkHom changed: the direction of the equality flipped to match with the dual.
HomologicalComplex.Hom.sqFrom gained a simps! attribute to replace two manually written lemmas.
ChainComplex.mkAux and ChainComplex.mkHomAux needed to use to_dual existing, because to_dual currently doesn't like recursive definitions that use a match for the recursion.
mkXIso and mk'XIso and a few theorems didn't have duals before this PR.
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>
The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit b348a07).
The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech debtFixes cross-cutting technical debt, see the "technical debt counters" stream on zulip
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
to_dualonHomologicalComplex, makingChainComplexdual toCochainComplex.CochainComplex.ofHomandCochainComplex.mkHomchanged: the direction of the equality flipped to match with the dual.HomologicalComplex.Hom.sqFromgained asimps!attribute to replace two manually written lemmas.ChainComplex.mkAuxandChainComplex.mkHomAuxneeded to useto_dual existing, becauseto_dualcurrently doesn't like recursive definitions that use a match for the recursion.mkXIsoandmk'XIsoand a few theorems didn't have duals before this PR.to_dual#43804