Skip to content

feat(Order/Lattice): generic membership lemmas under lattice operations - #44353

Open
artie2000 wants to merge 10 commits into
leanprover-community:masterfrom
artie2000:lattice_setlike
Open

artie2000 wants to merge 10 commits into
leanprover-community:masterfrom
artie2000:lattice_setlike

Conversation

@artie2000

@artie2000 artie2000 commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator
  • Add generic lemmas relating membership to lattice operations assuming IsMemLE
  • Tag these lemmas membership, and update a test

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

PR summary 01915b0050

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Order.Lattice.SetLike (new file) 281

Declarations diff (regex)

+ mem_of_mem_bot
+ mem_of_mem_inf_left
+ mem_of_mem_inf_right
+ mem_sup_left
+ mem_sup_right
+ mem_top_of_mem

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 01915b0).

  • +6 new declarations
  • −0 removed declarations
+mem_of_mem_bot
+mem_of_mem_inf_left
+mem_of_mem_inf_right
+mem_sup_left
+mem_sup_right
+mem_top_of_mem

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 01915b0050
Reference commit c47f9ad906

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 30, 2026
@artie2000
artie2000 requested a review from JovanGerb September 30, 2026 12:13
Removed theorem mem_sup_of_mem_or_mem for simplification.
@artie2000

Copy link
Copy Markdown
Collaborator Author

TODO : membership tags; change final SetLike test

@artie2000 artie2000 added the WIP Work in progress label Oct 23, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 24, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 11, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 11, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

This PR/issue depends on:

@artie2000 artie2000 removed the WIP Work in progress label Nov 11, 2026
@artie2000 artie2000 changed the title feat(Order/Lattice): generic lemmas about membership under lattice operations feat(Order/Lattice): lemmas about membership under lattice operations Nov 11, 2026
@artie2000 artie2000 changed the title feat(Order/Lattice): lemmas about membership under lattice operations feat(Order/Lattice): generic membership lemmas under lattice operations Nov 21, 2026
@artie2000 artie2000 added the t-meta Tactics, attributes or user commands label Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant