Repository navigation
feat(Order): SupClosed/DirSupClosed/DirectedOn/etc for set intervals
#43536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SnirBroshi
wants to merge
14
commits into
leanprover-community:master
Choose a base branch
from
SnirBroshi:feature/order/sup-closed-inacc-intervals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+250
−23
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c4b89ed
feat(Order): `SupClosed`/`DirSupClosed`/`DirectedOn`/etc for set inte…
SnirBroshi 1f31eec
`IsOpen`/`IsClosed` for `IsUpperSet`/`IsLowerSet`
SnirBroshi d6b49f4
`protected`
SnirBroshi ec3106d
Merge branch 'master' of github.com:leanprover-community/mathlib4 int…
SnirBroshi e95e23c
Merge branch 'master' into feature/order/sup-closed-inacc-intervals
SnirBroshi f023266
Merge branch 'master' of github.com:leanprover-community/mathlib4 int…
SnirBroshi 76eb4a7
fix `+typeChanged` warnings
SnirBroshi e857429
update deprecation dates
SnirBroshi 3707b88
fix
SnirBroshi 41cdd59
fix
SnirBroshi 930b43a
Merge branch 'master' of github.com:leanprover-community/mathlib4 int…
SnirBroshi 30c1ccd
Merge branch 'master' of github.com:leanprover-community/mathlib4 int…
SnirBroshi 7745b9e
`IsClopen.{Iic,Ioi,Ioc}` in `IsScottHausdorff`
SnirBroshi f6ade12
Merge branch 'master' into feature/order/sup-closed-inacc-intervals
SnirBroshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the theorems that you've added in this section are strange. I get that the point is they are just for convenience, but do you actually have a use case for them? If anything, this suggests to me that maybe we're missing a
LUBClosedpredicate, whereLUBClosed s := ∀ t, t ⊆ s → t.Nonempty → ∀ u, IsLUB t u → u ∈ s.And then
LUBClosedimpliesCountableSupClosed. I realize this is almost, but not quiteDirSupClosed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DirSupClosedandLUBClosedare the same over linear orders. Is there ever a situation where we want to talk aboutLUBClosedin a partial order, rather thanDirSupClosed?I've mentioned this before, but
DirSupClosedhas nicer closure properties (they're closed under unions, whileLUBClosedsets wouldn't be) so I suspect that it's not what we want in most scenarios.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not currently using
CountableSupClosedfor anything, but I think it's valuable to complete the API for when the moment comes. I am constantly having to stop what I'm doing to prove trivialities in various APIs, so this is preemptive. I think set intervals are fundamental enough to get this treatment for any predicate about sets.I agree these are lub/glb closed, and that's even true without
Nonempty, but I imagine we're not going to add 4 new predicates (lub/glb, with/without nonempty) just because they hold on intervals.Should I add
LUBClosed&GLBClosed?This is similar to how we have both
ScottContinuousandLeftOrdContinuous, that differ by theDirectedOnrequirement.btw I think a dual to
DirSupClosed(DirInfClosed) would be nice.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any use for the dual? Do we also want to dualize Scott continuity?
I think this is all nonsense busy work until someone comes up with a good use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, at least I think so. Of course the sup versions are more common, but the duals are useful.
See e.g. #42661 (comment)
(spelling it this way makes theorems easier and IMO helps thinking about this)