Skip to content

feat(Combinatorics/Design/Defs): definitions of Steiner systems - #41802

Open
tb65536 wants to merge 12 commits into
leanprover-community:masterfrom
tb65536:tb_design
Open

tb65536 wants to merge 12 commits into
leanprover-community:masterfrom
tb65536:tb_design

Conversation

@tb65536

@tb65536 tb65536 commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

@tb65536 tb65536 added WIP Work in progress awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-combinatorics Combinatorics labels Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

PR summary 57a1e1368f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ IsBalanced
+ IsBalanced.discrete
+ IsBalanced.indiscrete
+ IsDesign
+ IsDesign.discrete
+ IsDesign.finite
+ IsDesign.indiscrete
+ IsDesign.nonempty
+ IsSteiner
+ IsSteiner.discrete
+ IsSteiner.indiscrete
+ IsSteiner.isSimple
+ subsingleton_of_ncard_eq_one

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 57a1e13).

  • +27 new declarations
  • −0 removed declarations
+IncidenceSystem.IsBalanced
+IncidenceSystem.IsBalanced.balanced
+IncidenceSystem.IsBalanced.casesOn
+IncidenceSystem.IsBalanced.discrete
+IncidenceSystem.IsBalanced.indiscrete
+IncidenceSystem.IsBalanced.mk
+IncidenceSystem.IsBalanced.rec
+IncidenceSystem.IsBalanced.recOn
+IncidenceSystem.IsDesign
+IncidenceSystem.IsDesign.card_carrier
+IncidenceSystem.IsDesign.casesOn
+IncidenceSystem.IsDesign.discrete
+IncidenceSystem.IsDesign.finite
+IncidenceSystem.IsDesign.indiscrete
+IncidenceSystem.IsDesign.mk
+IncidenceSystem.IsDesign.nonempty
+IncidenceSystem.IsDesign.rec
+IncidenceSystem.IsDesign.recOn
+IncidenceSystem.IsDesign.toIsBalanced
+IncidenceSystem.IsDesign.toIsUniform
+IncidenceSystem.IsSteiner
+IncidenceSystem.IsSteiner.discrete
+IncidenceSystem.IsSteiner.indiscrete
+IncidenceSystem.IsSteiner.isSimple
+IncidenceSystem.isBalanced_iff
+IncidenceSystem.isDesign_iff
+Set.subsingleton_of_ncard_eq_one

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 57a1e1368f
Reference commit 15cf10d19d

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@tb65536 tb65536 changed the title feat(Combinatorics/Design/Defs): definitions of combinatorial designs feat(Combinatorics/Design/Defs): definitions of Steiner systems Jul 16, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 5, 2026
@joneugster
joneugster marked this pull request as draft October 24, 2026 02:07
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 11, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 11, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

Comment thread Mathlib/Combinatorics/Design/Defs.lean Resolved
@github-actions github-actions Bot added large-import Automatically added label for PRs with a significant increase in transitive imports and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Nov 12, 2026
pre-commit-ci-lite Bot and others added 5 commits November 12, 2026 15:07
These commands made the changes in this commit.
To make the same fixes yourself, run them in your mathlib4 checkout.
@tb65536 tb65536 removed the WIP Work in progress label Nov 12, 2026
@tb65536
tb65536 marked this pull request as ready for review November 12, 2026 15:56
@github-actions github-actions Bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 12, 2026
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Nov 12, 2026
Comment thread Mathlib/Combinatorics/Design/Defs.lean Resolved
card_carrier := rfl

theorem IsDesign.nonempty {d : IncidenceSystem α β} {t n k l : ℕ}
(hd : d.IsDesign t n k l) (hk : n ≠ 0) : d.carrier.Nonempty := by

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(hd : d.IsDesign t n k l) (hk : n ≠ 0) : d.carrier.Nonempty := by
(hd : d.IsDesign t n k l) (hn : n ≠ 0) : d.carrier.Nonempty := by

and similarly below

Comment on lines +220 to +222
obtain ⟨s, hs, hst⟩ := Set.exists_subset_card_eq (htk.trans (hd.uniform hb₁).ge)
exact Set.subsingleton_of_ncard_eq_one
(hd.balanced s (hs.trans (d.block_subset hb₁)) hst) ⟨hb₁, hs⟩ ⟨hb₂, hs.trans_eq h⟩

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
obtain ⟨s, hs, hst⟩ := Set.exists_subset_card_eq (htk.trans (hd.uniform hb₁).ge)
exact Set.subsingleton_of_ncard_eq_one
(hd.balanced s (hs.trans (d.block_subset hb₁)) hst) ⟨hb₁, hs⟩ ⟨hb₂, hs.trans_eq h⟩
obtain ⟨s, hs, hst⟩ := Set.exists_subset_card_eq (hd.uniform hb₁ ▸ htk)
exact Set.subsingleton_of_ncard_eq_one
(hd.balanced s (hs.trans (d.block_subset hb₁)) hst) ⟨hb₁, hs⟩ ⟨hb₂, h ▸ hs⟩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants