Repository navigation
Conversation
PR summary 2d34e0f1f3Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (weak) |
|---|---|---|
| 3 | 1 | large files |
Current commit 2d34e0f1f3
Reference commit 5d0d3c0c77
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Continuous.re and similar to expand dot notation
Continuous.re and similar to expand dot notationContinuous.re and similar
|
Thanks for the review @j-loreaux! I thought about the issue with the naming, but I saw that docs#MeasureTheory.Integrable.re already exists. I am not sure how to name it to include |
|
Thanks for pushing back a bit on this. On second thought, let's just leave it so there are only |
|
Sorry for the delay, There is also -awaiting-author |
|
This pull request has conflicts, please merge |
|
@ster-oc do you have any interest in taking this up again? |
|
@j-loreaux Yes, absolutely! |
|
@j-loreaux I had to disable the 1500 lines linter in |
|
-awaiting-author |
j-loreaux
left a comment
There was a problem hiding this comment.
I'm pretty happy with this. The only real issue is that things that reference RCLike.re, RCLike.im, or RCLike.ofReal should have rclike somewhere in the name. In general, I would suggest things like Continuous.rclike_re and similar.
Thanks! @ster-oc
| reCLM.continuous | ||
|
|
||
| open Filter in | ||
| theorem _root_.Filter.Tendsto.re (hf : Tendsto f l (𝓝 a)) : |
There was a problem hiding this comment.
Let's do this here and in the ones below, so that rclike appears in the name somewhere.
| theorem _root_.Filter.Tendsto.re (hf : Tendsto f l (𝓝 a)) : | |
| theorem _root_.Filter.Tendsto.rclike_re (hf : Tendsto f l (𝓝 a)) : |
I think we were already discussing this same issue months ago. -awaiting-author |
|
Oh, I apologize. I remember that now. Okay, let's just go with this version and if they get inconvenient then we can change them later. Thanks! bors merge |
|
bors r- |
|
Bors build canceled. Address comments or fix if necessary, and then someone with permission can run |
|
oops, I thought I saw a green check on this? bors d+ |
|
✌️ ster-oc can now approve this pull request until 2026-12-04 16:39 UTC (in 2 weeks). To approve and merge, reply with
|
|
Ups, downstream of Thank you very much for the reviews @j-loreaux! |
|
As this PR is labelled bors merge |
This PR adds dot notation for `re`, `im`, `conj` and `ofReal` for `Continuous`, `LipschitzWith` and `Memℓp`. Given `hf : Continuous f` it allows to use `hf.re` to express `Continuous (fun x ↦ (f x).re)`, similarly to the usual `hf.add hg`. I also can add the same features for `Summable` but I am not sure where to place them, suggestions are appreciated! Co-authored-by: ster99 <stefano.rocca.99@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
Continuous.re and similarContinuous.re and similar
This PR adds dot notation for
re,im,conjandofRealforContinuous,LipschitzWithandMemℓp.Given
hf : Continuous fit allows to usehf.reto expressContinuous (fun x ↦ (f x).re), similarly to the usualhf.add hg.I also can add the same features for
Summablebut I am not sure where to place them, suggestions are appreciated!