Repository navigation
chore: clean up after #43233 - #45649
riccardobrasca wants to merge 21 commits into
Conversation
PR summary 2b4c39255d
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.LSeries.WienerIkehara | 3162 | 3161 | -1 (-0.03%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.LSeries.WienerIkehara |
-1 |
Declarations diff (regex)
+ HasCompactSupport.summable_mul_natCast_div
+ IsWienerIkehara
+ LSeriesSummable_of_sum_range_le_and_nonneg
+ Real.exists_contDiff_indicator_Icc_le_le_indicator_Ioo
+ Real.fourierChar_mul_log_div_two_pi
+ Real.tendsto_integral_cpow_mul_I_smul_atTop
+ _root_.HasCompactSupport.comp_exp
+ _root_.IsWienerIkehara.A_nonneg
+ _root_.hasCompactMulSupport_mulIndicator
+ antitoneOn_inv_mul_weight_div
+ antitoneOn_weight
+ antitone_ite_weight
+ continuous_fourierSeminorm
+ continuous_seminorm
+ eventually_setIntegral_Ioi_eq_of_eventuallyEq_zero
+ exists_norm_remainder_one_le
+ fourierSeminorm
+ fourierSeminorm_nonneg
+ hasDerivAt_weight
+ integrableOn_inv_mul_weight_div
+ integrableOn_mul_weight_div
+ inv_mul_weight_div
+ inv_mul_weight_div_le_one
+ norm_fourier_le_fourierSeminorm_mul
+ poleTerm
+ poleTerm_fourier_eq
+ poleTerm_one
+ remainder
+ remainder_fourier_eq
+ remainder_one_fourier_sub
+ smoothedSum
+ smoothedSum_fourier_eq
+ sum_range_ite_weight_le
+ tendsto_poleTerm
+ tendsto_remainder_one_fourier
+ tendsto_remainder_one_fourier_of_hasCompactSupport
+ tendsto_smoothedSum
+ tsum_mul_indicator_Ico_natCast_div
+ weight
+ weight_nonneg
- (exists_cutoff)
- A_nonneg
- C₀
- C₀_nonneg
- Q
- Q_nonneg
- S
- S_one_sub
- S₁
- S₂
- S₂_one
- antitoneOn_inv_mul_w_div
- antitoneOn_w
- antitone_ite_w
- continuous_Q
- continuous_cpow_mul_I
- c₀
- eventually_eq_zero_of_tsupport_subset
- eventually_setIntegral_Ioi_inv_eq
- exists_norm_S_one_le
- fourierChar_neg_mul_log_div
- hasCompactSupport_comp_exp
- hasCompactSupport_indicator_Ico
- hasDerivAt_w
- integrableOn_inv_mul_w_div
- integrableOn_mul_w_div
- integral_exp_mul_fourier_eq
- inv_mul_w_div
- inv_mul_w_div_le_one
- lSeriesSummable
- mul_integral_exp_mul_fourierChar_eq
- norm_fourier_le_Q_mul
- sum_range_ite_w_le
- sum_term_mul_fourier_eq
- sum_term_mul_sub_mul_integral_eq
- summable_mul
- tendsto_S_one_fourier
- tendsto_S_one_fourier_of_hasCompactSupport
- tendsto_S₁
- tendsto_S₂
- tendsto_integral_G_mul
- tendsto_integral_mul_cpow_mul_I
- tsum_mul_indicator_Ico
- w
- w_nonneg
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean -- stale, waiting for the new build)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
b45626b).
- +23 new declarations
- −0 removed declarations
+ContDiffBump.mk.congr_simp
+HasCompactSupport.comp_exp
+HasCompactSupport.summable_mul_natCast_div
+IsWienerIkehara
+IsWienerIkehara.A_nonneg
+IsWienerIkehara.C_nonneg
+IsWienerIkehara.casesOn
+IsWienerIkehara.continuousOn
+IsWienerIkehara.eqOn
+IsWienerIkehara.mk
+IsWienerIkehara.nonneg
+IsWienerIkehara.rec
+IsWienerIkehara.recOn
+IsWienerIkehara.sum_range_le
+LSeriesSummable_of_sum_range_le_and_nonneg
+MeasureTheory.eventually_setIntegral_Ioi_eq_of_eventuallyEq_zero
+Real.exists_contDiff_indicator_Icc_le_le_indicator_Ioo
+Real.fourierChar_mul_log_div_two_pi
+Real.tendsto_integral_cpow_mul_I_smul_atTop
+SchwartzMap.continuous_seminorm
+hasCompactMulSupport_mulIndicator
+hasCompactSupport_indicator
+tsum_mul_indicator_Ico_natCast_divNo changes to strong technical debt.
No changes to weak technical debt.
Current commit 2b4c39255d
Reference commit 9c8f67d65b
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
mcdoll
left a comment
There was a problem hiding this comment.
Thanks!
I am not at my laptop, so some improvements will have to wait until tomorrow.
j-loreaux
left a comment
There was a problem hiding this comment.
This is still marking all these as private. Is that really what we want? I suspect not.
Let me do another pass of things we can move, but most of the declarations are about objects defined in this very file in order to prove the final theorem. |
|
This pull request has conflicts, please merge |
Resolve the WienerIkehara conflict by preserving the weight renaming and upstream's eventuallySubset update.
MichaelStollBayreuth
left a comment
There was a problem hiding this comment.
I think the variables in the WienerIkehara file need some cleaning up (i.e., some of them should get narrower scopes).
But in any case, thanks for doing this!
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
|
@MichaelStollBayreuth thanks for the detailed review! I've applied all your suggestion and addressed the remaining comments in 2b4c392. I am almost sure I've done everything you suggested, but since fixing variables implied moving stuff around it's a bit difficult to be 100% sure. Anyway the worst can happen is that some variable is still declared twice. |
#43233 was merged too quickly, we clean it up.