Skip to content

chore: clean up after #43233 - #45649

Open
riccardobrasca wants to merge 21 commits into
leanprover-community:masterfrom
riccardobrasca:RB/ops
Open

riccardobrasca wants to merge 21 commits into
leanprover-community:masterfrom
riccardobrasca:RB/ops

Conversation

@riccardobrasca

@riccardobrasca riccardobrasca commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

#43233 was merged too quickly, we clean it up.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

PR summary 2b4c39255d

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.NumberTheory.LSeries.WienerIkehara 3162 3161 -1 (-0.03%)
Import changes for all files
Files Import difference
Mathlib.NumberTheory.LSeries.WienerIkehara -1

Declarations diff (regex)

+ HasCompactSupport.summable_mul_natCast_div
+ IsWienerIkehara
+ LSeriesSummable_of_sum_range_le_and_nonneg
+ Real.exists_contDiff_indicator_Icc_le_le_indicator_Ioo
+ Real.fourierChar_mul_log_div_two_pi
+ Real.tendsto_integral_cpow_mul_I_smul_atTop
+ _root_.HasCompactSupport.comp_exp
+ _root_.IsWienerIkehara.A_nonneg
+ _root_.hasCompactMulSupport_mulIndicator
+ antitoneOn_inv_mul_weight_div
+ antitoneOn_weight
+ antitone_ite_weight
+ continuous_fourierSeminorm
+ continuous_seminorm
+ eventually_setIntegral_Ioi_eq_of_eventuallyEq_zero
+ exists_norm_remainder_one_le
+ fourierSeminorm
+ fourierSeminorm_nonneg
+ hasDerivAt_weight
+ integrableOn_inv_mul_weight_div
+ integrableOn_mul_weight_div
+ inv_mul_weight_div
+ inv_mul_weight_div_le_one
+ norm_fourier_le_fourierSeminorm_mul
+ poleTerm
+ poleTerm_fourier_eq
+ poleTerm_one
+ remainder
+ remainder_fourier_eq
+ remainder_one_fourier_sub
+ smoothedSum
+ smoothedSum_fourier_eq
+ sum_range_ite_weight_le
+ tendsto_poleTerm
+ tendsto_remainder_one_fourier
+ tendsto_remainder_one_fourier_of_hasCompactSupport
+ tendsto_smoothedSum
+ tsum_mul_indicator_Ico_natCast_div
+ weight
+ weight_nonneg
- (exists_cutoff)
- A_nonneg
- C₀
- C₀_nonneg
- Q
- Q_nonneg
- S
- S_one_sub
- S₁
- S₂
- S₂_one
- antitoneOn_inv_mul_w_div
- antitoneOn_w
- antitone_ite_w
- continuous_Q
- continuous_cpow_mul_I
- c₀
- eventually_eq_zero_of_tsupport_subset
- eventually_setIntegral_Ioi_inv_eq
- exists_norm_S_one_le
- fourierChar_neg_mul_log_div
- hasCompactSupport_comp_exp
- hasCompactSupport_indicator_Ico
- hasDerivAt_w
- integrableOn_inv_mul_w_div
- integrableOn_mul_w_div
- integral_exp_mul_fourier_eq
- inv_mul_w_div
- inv_mul_w_div_le_one
- lSeriesSummable
- mul_integral_exp_mul_fourierChar_eq
- norm_fourier_le_Q_mul
- sum_range_ite_w_le
- sum_term_mul_fourier_eq
- sum_term_mul_sub_mul_integral_eq
- summable_mul
- tendsto_S_one_fourier
- tendsto_S_one_fourier_of_hasCompactSupport
- tendsto_S₁
- tendsto_S₂
- tendsto_integral_G_mul
- tendsto_integral_mul_cpow_mul_I
- tsum_mul_indicator_Ico
- w
- w_nonneg

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- stale, waiting for the new build)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit b45626b).

  • +23 new declarations
  • −0 removed declarations
+ContDiffBump.mk.congr_simp
+HasCompactSupport.comp_exp
+HasCompactSupport.summable_mul_natCast_div
+IsWienerIkehara
+IsWienerIkehara.A_nonneg
+IsWienerIkehara.C_nonneg
+IsWienerIkehara.casesOn
+IsWienerIkehara.continuousOn
+IsWienerIkehara.eqOn
+IsWienerIkehara.mk
+IsWienerIkehara.nonneg
+IsWienerIkehara.rec
+IsWienerIkehara.recOn
+IsWienerIkehara.sum_range_le
+LSeriesSummable_of_sum_range_le_and_nonneg
+MeasureTheory.eventually_setIntegral_Ioi_eq_of_eventuallyEq_zero
+Real.exists_contDiff_indicator_Icc_le_le_indicator_Ioo
+Real.fourierChar_mul_log_div_two_pi
+Real.tendsto_integral_cpow_mul_I_smul_atTop
+SchwartzMap.continuous_seminorm
+hasCompactMulSupport_mulIndicator
+hasCompactSupport_indicator
+tsum_mul_indicator_Ico_natCast_div

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 2b4c39255d
Reference commit 9c8f67d65b

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@riccardobrasca riccardobrasca added the WIP Work in progress label Nov 4, 2026
@riccardobrasca riccardobrasca removed the WIP Work in progress label Nov 4, 2026
@riccardobrasca
riccardobrasca requested a review from mcdoll November 4, 2026 08:18

@mcdoll mcdoll left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I am not at my laptop, so some improvements will have to wait until tomorrow.

@j-loreaux j-loreaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still marking all these as private. Is that really what we want? I suspect not.

@riccardobrasca

Copy link
Copy Markdown
Member Author

This is still marking all these as private. Is that really what we want? I suspect not.

Let me do another pass of things we can move, but most of the declarations are about objects defined in this very file in order to prove the final theorem.

@riccardobrasca riccardobrasca added the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Nov 4, 2026
@riccardobrasca riccardobrasca removed the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Nov 5, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 6, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

Resolve the WienerIkehara conflict by preserving the weight renaming and upstream's eventuallySubset update.
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 6, 2026
@tb65536 tb65536 added t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-analysis Analysis (normed *, calculus) labels Nov 13, 2026

@MichaelStollBayreuth MichaelStollBayreuth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the variables in the WienerIkehara file need some cleaning up (i.e., some of them should get narrower scopes).

But in any case, thanks for doing this!

@MichaelStollBayreuth MichaelStollBayreuth added the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Nov 21, 2026
riccardobrasca and others added 2 commits November 22, 2026 08:36
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
riccardobrasca and others added 8 commits November 22, 2026 08:36
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
@riccardobrasca

Copy link
Copy Markdown
Member Author

@MichaelStollBayreuth thanks for the detailed review! I've applied all your suggestion and addressed the remaining comments in 2b4c392. I am almost sure I've done everything you suggested, but since fixing variables implied moving stuff around it's a bit difficult to be 100% sure. Anyway the worst can happen is that some variable is still declared twice.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. t-analysis Analysis (normed *, calculus) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants