feat(web): playwright screenshot support#3047
Open
vishna wants to merge 5 commits into
Open
Conversation
vishna
requested review from
fylyppo,
mateuszwojtczak,
pdenert and
piotruela
as code owners
github-actions
Bot
added
the
package: patrol
vishna
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a screenshot feature for the web platform in Patrol. It adds the screenshot method to the WebAutomator interface and its implementation, creates a new Playwright action, and updates the corresponding request contracts. Feedback focuses on maintaining alphabetical consistency in imports and type definitions, as well as improving the robustness of the screenshot action by ensuring the target directory exists before saving the file.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
screenshotmethod for the web platform, enabling automated screenshot capture during web integration tests. It integrates Playwright's native screenshot capabilities into the PatrolWebAutomatorAPI.Changes
packages/patrolscreenshot({required String path})to theWebAutomatorinterface.WebAutomator.screenshotto send ascreenshotcommand to the Playwright runner.web_runner(Playwright)screenshotaction inpackages/patrol/web_runner/tests/actions/screenshot.tsusingpage.screenshot().actions.tsandcontracts.tsto register and map the new screenshot request.Verification
$.platform.web.screenshot(path: 'path/to/screenshot.png')correctly triggers Playwright to save a screenshot at the specified location.