Skip to content

Bump to protobuf==3.18.3 within lbry-sdk repo causes MacOS unit test failures #121

Description

@moodyjon

Hub/setup.py protobuf version was bumped in this change:

75d64f9

However, when I try to apply a corresponding change in lbry-sdk/setup.py:

(lbry-venv) swdev1@Jonathans-Mac-mini lbry-sdk % git diff
diff --git a/setup.py b/setup.py
index bd468c687..4c736f646 100644
--- a/setup.py
+++ b/setup.py
@@ -37,7 +37,7 @@ setup(
         'base58==1.0.0',
         'cffi==1.13.2',
         'cryptography==2.5',
-        'protobuf==3.17.2',
+        'protobuf==3.18.3',
         'prometheus_client==0.7.1',
         'ecdsa==0.13.3',
         'pyyaml==5.3.1',
@@ -57,7 +57,7 @@ setup(
             'jsonschema==4.4.0',
         ],
         'hub': [
-            'hub@git+https://github.com/lbryio/hub.git@929448d64bcbe6c5e476757ec78456beaa85e56a'
+            'hub@git+https://github.com/lbryio/hub.git@75d64f9dc6d3b2c913b8b10053bd3589e7a2e8eb'
         ]
     },
     classifiers=[

The MacOS unit tests start to fail:

https://github.com/moodyjon/lbry-sdk/actions/runs/3933945634

I'm uncertain whether this is due to use of "coverage" tool, GitHub CI, or OS/arch issue.

Unit tests work fine when run locally on my machine (MacOS 13.1 / arm64). I have a development branch which was bumped to "protobuf==3.20.1" for other reasons (stringmap_extensions), and it didn't have the same effect of breaking the test.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: highWork needs to be moved into sprint ASAP

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions