Skip to content

Add InsertDriveFile icon#1527

Merged
Rajesh-Nagarajan-11 merged 2 commits into
layer5io:masterfrom
nafisa404:codex-add-insert-drive-file-icon
May 11, 2026
Merged

Add InsertDriveFile icon#1527
Rajesh-Nagarajan-11 merged 2 commits into
layer5io:masterfrom
nafisa404:codex-add-insert-drive-file-icon

Conversation

@nafisa404
Copy link
Copy Markdown
Contributor

Description

Adds InsertDriveFileIcon to Sistent so Layer5 products can use the local icon library instead of importing InsertDriveFile from @mui/icons-material.

Closes #1515.

Changes

  • Added InsertDriveFileIcon using the filled Material UI InsertDriveFile SVG path.
  • Exported the icon through src/icons/InsertDriveFile and the central icon barrel.
  • Added a focused render/dimension test for the new icon.

Validation

  • npx jest src/__testing__/InsertDriveFileIcon.test.tsx --runInBand
  • Full Jest suite via commit hook: 14 suites / 48 tests passed
  • $env:NODE_ENV='production'; npx tsup

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the InsertDriveFileIcon component, including its implementation, unit tests, and export configuration. The feedback focuses on improving the test suite by using non-default dimensions to ensure props are correctly applied and enhancing the component's accessibility by supporting a title prop for screen readers.

Comment thread src/__testing__/InsertDriveFileIcon.test.tsx Outdated
Comment thread src/icons/InsertDriveFile/InsertDriveFileIcon.tsx
@github-actions
Copy link
Copy Markdown

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

@nafisa404 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

Comment thread src/__testing__/InsertDriveFileIcon.test.tsx Outdated
@nafisa404 nafisa404 force-pushed the codex-add-insert-drive-file-icon branch from 2bcac42 to 8730c57 Compare May 11, 2026 13:26
@nafisa404
Copy link
Copy Markdown
Contributor Author

@Rajesh-Nagarajan-11 @rishiraj38 Thanks for the clarification. I’ve removed the separate test file and kept the icon implementation unchanged.Also fixed the DCO failure by adding the required signoffs.

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

@rishiraj38 Raise a new issue for single test file for that covers all icons

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 merged commit 38f9549 into layer5io:master May 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add InsertDriveFileIcon to Sistent

4 participants