Add InsertDriveFile icon#1527
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the InsertDriveFileIcon component, including its implementation, unit tests, and export configuration. The feedback focuses on improving the test suite by using non-default dimensions to ensure props are correctly applied and enhancing the component's accessibility by supporting a title prop for screen readers.
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
|
@nafisa404 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Signed-off-by: Nafisa Tahasin <[email protected]>
Signed-off-by: Nafisa Tahasin <[email protected]>
2bcac42 to
8730c57
Compare
|
@Rajesh-Nagarajan-11 @rishiraj38 Thanks for the clarification. I’ve removed the separate test file and kept the icon implementation unchanged.Also fixed the DCO failure by adding the required signoffs. |
|
@rishiraj38 Raise a new issue for single test file for that covers all icons |
Description
Adds
InsertDriveFileIconto Sistent so Layer5 products can use the local icon library instead of importingInsertDriveFilefrom@mui/icons-material.Closes #1515.
Changes
InsertDriveFileIconusing the filled Material UIInsertDriveFileSVG path.src/icons/InsertDriveFileand the central icon barrel.Validation
npx jest src/__testing__/InsertDriveFileIcon.test.tsx --runInBand$env:NODE_ENV='production'; npx tsup