feat: add IBigSegmentStore interface + Redis and DynamoDB stores#536
Open
beekld wants to merge 6 commits into
Open
feat: add IBigSegmentStore interface + Redis and DynamoDB stores#536beekld wants to merge 6 commits into
beekld wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0082f6e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Ticket: SDK-2363 · Follows #534
Summary
Adds the public
IBigSegmentStoreinterface, theMembership/StoreMetadatavalue types, and concrete DynamoDB + Redis implementations. Schema strings match what the Relay Proxy writes.Design notes
synchronizedOnparsing. Stored as DynamoDB N / Redis string. Both stores reject malformed values (non-numeric strings, wrong DynamoDB attribute type) rather than silently returning 0, matching the existingdynamodb_source.cpprow validation.Not in scope
BigSegmentsBuilderconfig plumbing.BigSegmentStoreWrapper(LRU cache + staleness polling) and the hashing path.rules.cppbig-segments TODO.Test plan
Membershipunit tests pass.RedisBigSegmentStoreintegration tests pass against Redis 7 (docker).DynamoDBBigSegmentStoreintegration tests pass against DynamoDB Local.Note
Medium Risk
New evaluation-adjacent persistence APIs and external-store reads; behavior is well-tested but not yet on the hot path until wrapper/evaluator land.
Overview
Introduces Big Segments read-only persistence for the C++ server SDK: a public
IBigSegmentStorecontract plusMembership/StoreMetadatavalue types, with Redis and DynamoDB stores that match Relay Proxy key/layout conventions (prefix-scoped, shared tables/DBs with existing data sources).Stores implement opaque context-hash membership lookups (include/exclude segment refs, inclusion wins on overlap) and staleness metadata (
synchronizedOn), with strict validation on malformed DynamoDB attribute types and non-numeric sync timestamps instead of silent empty/zero results. CMake and integration tests coverMembershipsemantics, Redis/DynamoDB happy paths, prefix isolation, and error paths.Not in this PR: config builder wiring, caching/staleness wrapper, context hashing, or flag evaluation integration.
Reviewed by Cursor Bugbot for commit b99bf0c. Bugbot is set up for automated code reviews on this repo. Configure here.