Draft: Claude Code implementation of a replacement for jkg_utils that runs faster#7
Open
BrendanKKrueger wants to merge 45 commits intomainfrom
Open
Draft: Claude Code implementation of a replacement for jkg_utils that runs faster#7BrendanKKrueger wants to merge 45 commits intomainfrom
BrendanKKrueger wants to merge 45 commits intomainfrom
Conversation
…aster. Claimed 20-200x speedup, but I've not tested or read through the code.
…written by Claude) now passes, but I've not verified anything. The benchmark shows a whopping 1x speedup (in other words: no change). Let's see if Claude can do better.
…a time-limited Monte Carlo routine, and that the better measure is not wall time but throughput.
…new implementations.
…e the equations, and verify the equations from jkg_utils.
… and it claims to have found some problems.
… by the step counts not varying correctly with the total timestep. It misdiagnosed the cause, but I was able to figure out what went wrong once Claude Code pointed to the existence of a problem.
…Claude wanted to put it in a different location than I thought was appropriate, so I'm making the change manually.
… few million samples, now close to a billion.
…document because we don't need that in the main branch.
…tly small systems.
…er early if convergence criteria are met.
…curious if it fails, makes up nonsense, makes up something that _seems_ good but is actually wrong and hard to prove wrong, or gets it right.
…fourth-order method, so we can study what it did, if the results are valid, how to extend them to other Trotter methods, etc.
BrendanKKrueger
force-pushed
the
bkk_commutator
branch
from
0fb3cc7 to
3a48a0b
Compare
… the testing into a single file.
… in, but I'm not ready to delete it yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a test of using Claude Code, because actually mucking around with jkg_utils is a really low priority right now.