fix: handle integration marketplace install callbacks#38236
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #38236 +/- ##
==========================================
+ Coverage 85.35% 85.36% +0.01%
==========================================
Files 4959 4960 +1
Lines 258802 259086 +284
Branches 49088 49187 +99
==========================================
+ Hits 220889 221171 +282
- Misses 33606 33608 +2
Partials 4307 4307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hjlarry
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fix marketplace install callbacks launched from Integrations so users return to the right Integration category and the selected package is installed from the callback URL instead of being dropped by route redirects.
This PR:
/pluginsURLs redirect into Integrations/integrations/<category>/pluginsso the category page stays mounted and can consumepackage-idsVerification:
pnpm -C web test app/components/header/account-setting/model-provider-page/__tests__/install-from-marketplace.spec.tsx app/components/header/account-setting/data-source-page-new/__tests__/install-from-marketplace.spec.tsx app/components/integrations/__tests__/page.spec.tsx app/components/integrations/__tests__/plugin-category-page.spec.tsx app/components/plugins/plugin-page/__tests__/index.spec.tsx app/components/plugins/__tests__/plugin-routes.spec.ts app/components/integrations/__tests__/routes.spec.tspnpm -C web type-checkpnpm -C packages/dify-ui type-checkpnpm -C packages/dify-ui exec eslint src/dialog/index.tsx src/dialog/__tests__/index.spec.tsxpnpm -C packages/dify-ui test src/dialog/__tests__/index.spec.tsxbecause the local Playwright Chromium cache is missingchromium_headless_shellFrom Codex
Screenshots
package-ids, or require an extra dialog focus cleanup.package-ids, and avoid focusing the close button.Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods