refactor(model)!: remove obsolete llm polling context fields#350
Conversation
Assisted-by: Codex:GPT-5.4
There was a problem hiding this comment.
Code Review
This pull request removes the obsolete workflow_run_id and node_id parameters from the LLM polling interface across requests, executors, and the LargeLanguageModel base class. It also adds a runtime check to raise a migration error if legacy plugins still implement the outdated polling interface, and updates the test suite accordingly. Feedback on the changes suggests keeping json_schema as a keyword-only argument in start_polling to maintain consistency with _start_polling and prevent positional argument abuse.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Assisted-by: Codex:GPT-5.4
Assisted-by: Codex:GPT-5.4
AI disclosure: This PR was primarily drafted with Codex using GPT-5.4.
I have reviewed and edited the final diff, and I am responsible for the content.
Related Issue
Closes #349
Summary
workflow_run_idandnode_idfrom the LLM polling daemon request schemaLargeLanguageModelpolling method signaturesPluginExecutorCompatibility Impact
This is a breaking API change for plugin authors who implement polling-capable
LargeLanguageModelproviders against the SDK. Existing implementations must removeworkflow_run_idandnode_idfrom_start_pollingand_check_pollingbefore upgrading.Target release: the next incompatible SDK release after 0.9.0. The exact version number is still to be decided by maintainers.
Validation
uv run pytest tests/test_model_polling.py -qjust checkjust buildjust teststill reports the pre-existing integration environment error intests/integration/test_invoke_llm.py::test_invoke_llm, wherepython -m tests.__mock_serverfails withModuleNotFoundError: No module named 'tests'in this worktree\n\n# Pull Request Checklist\n\n## Compatibility Check\n\n- [x] I have checked whether this change affects the backward compatibility of the plugin declared inREADME.md\n- [x] I have checked whether this change affects the forward compatibility of the plugin declared inREADME.md\n- [ ] If this change introduces a breaking change, I have discussed it with the project maintainer and specified the release version in theREADME.md\n- [ ] I have described the compatibility impact and the corresponding version number in the PR description\n- [x] I have checked whether the plugin version is updated in theREADME.md\n\n## Available Checks\n\n- [x]just buildhas passed\n- [x] Relevant documentation has been updated (if necessary)