feat: sanitize terminal control characters in the output package - #237
Draft
Vladislav Nechakhin (vladislav-nechakhin) wants to merge 1 commit into
Draft
feat: sanitize terminal control characters in the output package#237Vladislav Nechakhin (vladislav-nechakhin) wants to merge 1 commit into
Vladislav Nechakhin (vladislav-nechakhin) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Text returned by the API is printed to the terminal as-is, so control characters in it are acted on by the terminal rather than displayed. This adds a printing API to
internal/outputthat replaces those characters with a visible placeholder, and makes the existing renderers use it. Pretty output now showsU+FFFDin their place; JSON output is unchanged.Key changes:
Printf,Println,Fprintf,Fprintln,Errorf,Errorln.PrintLines/FprintLinesfor multi-line text such as encoded JSON.PrintProxied/FprintProxiedfor output another program produced, where escape sequences must pass through untouched.OutputTable,OutputTreeandPrintRunsTablesanitize their titles, headers and cells; table rendering moved into a sharedTableTothat takes a writer.TruncateRunesreplaces the byte slice that shortened long run names, which could cut a multi-byte character in half.start_timeis parsed instead of byte-sliced at fixed offsets, so an unexpected value renders asN/A.PrintError, which had no callers.