Repository navigation
fix: pin PHP base image to 8.5.12 and pull phpMyAdmin image on upgrade - #1676
Merged
Merged
Conversation
jackbayliss
approved these changes
Oct 21, 2026
jackbayliss
left a comment
Collaborator
There was a problem hiding this comment.
Seems reasonable to me, nice
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PHP released fixes today for two critical unauthenticated RCE vulnerabilities, CVE-2026-109618 (memory corruption during OOM handling) and CVE-2026-109619 (stale global state across requests). Fixed versions are 8.5.12, 8.4.27, 8.3.36 and 8.2.35. All web SAPIs are affected, including PHP-FPM and Apache mod_php. Announcement: https://www.php.net/index.php#2026-10-20-1
Changes in this PR:
Dockerfile: pinFROM php:8.5.12-fpm. The changed tag is a cache miss on every host, so pulling this commit and rebuilding is enough to get the patched PHP. Dependabot's docker ecosystem is already configured for the root Dockerfile and the auto-merge workflow covers patch bumps, so future PHP point releases land automatically. With the floating tag dependabot had nothing to track.README.md: add adocker compose pull ogamex-phpmyadminstep to the upgrade instructions, before the rebuild.deploy-main.ymlanddeploy-release.yml: pull the phpMyAdmin image beforeup -d --build, so main.ogamex.dev and release.ogamex.dev get the patched phpMyAdmin on the next deploy. The app images on those servers were already re-pulled on each deploy because of the prune step, but the phpMyAdmin container keeps its image alive through the prune.No application code or PHP configuration changes. The php.net mitigations (memory_limit, post_max_size, session.upload_progress) are only partial workarounds and are not needed once the image is updated.
Type of Change:
Related Issues
Fixes #[issue-number]
Checklist
Before submitting this pull request, ensure all following requirements as outlined in CONTRIBUTING.md are met:
npm run build) if any changes are made to JS/CSS files.Additional Information
Add any additional context, screenshots, or explanations to help reviewers understand your PR. If this change introduces any breaking changes or significant impacts, please detail them here.