fix: resolve Interval constructor arity and Fact attributes when JIT is disabled#159
Open
abhiprd2000 wants to merge 1 commit into
Open
fix: resolve Interval constructor arity and Fact attributes when JIT is disabled#159abhiprd2000 wants to merge 1 commit into
abhiprd2000 wants to merge 1 commit into
Conversation
…n JIT is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a fatal
TypeErrorandAttributeErrorthat occurs when importing or executing PyReason with JIT compilation disabled (NUMBA_DISABLE_JIT=1). This unbricks the interpreted fallback layer and allows thedisable_jitunit test suite to run successfully.Changes:
Interval Proxy Arity: Intercepted variable arguments (
*args) inInterval.__new__to gracefully handle Numba's uncompiled reconstruction loop, and aligned the factory instantiation signature ininterval_type.py.Fact Model Attributes: Added public
.staticfield assignment to both PythonFactclass constructors to match expected access hooks during interpreted fact initialization.Fixes #158
Signed off : abhiprd2000