feat(dashboard): add guarded Visual Hive setup bridge#2002
Draft
DavidDiaz0317 wants to merge 22 commits into
Draft
feat(dashboard): add guarded Visual Hive setup bridge#2002DavidDiaz0317 wants to merge 22 commits into
DavidDiaz0317 wants to merge 22 commits into
Conversation
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
DavidDiaz0317
marked this pull request as draft
July 25, 2026 04:17
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Use the explicit bounded Codex home across integrated health and specialist paths. Quiesce the normal Visual Hive owner before both uninstall phases and retire only an exact completed workflow dispatch before baseline cleanup. Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
Signed-off-by: DavidDiaz0317 <DAVIDDIAZ031706@GMAIL.COM>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hive setupimplementation, managed setup PR, persistent state selection, audit trail, and ordinary Hive/dashboard runtime ownershipRoot cause
Hosted Hive correctly strips GitHub and GitHub App credentials from every agent terminal. The integrated setup CLI and stdio MCP server therefore cannot apply setup inside the hosted instance, even though the dashboard already has a separately authenticated owner and persistent state volume. There was no trusted control-plane bridge from that owner session to the existing setup implementation.
This was reproduced on
DavidDiaz0317/visual-hive-demo-siteafter the read-only setup plan passed on Hive4c6baa3: the supervisor terminal had neitherghnor readable/data/gh-user-token, by design. Copying a token into the terminal would weaken the security boundary, so this PR adds the missing owner-only bridge instead.Security properties
HIVE_GITHUB_TOKEN; the parent environment is unchangedValidation
go build ./...go vet ./...go test ./pkg/dashboard ./cmd/hive -run 'TestIntegratedSetup|TestDashboardIntegratedSetup|TestDashboardSetupEnvironment' -count=1 -timeout 5mgo test ./pkg/dashboard ./cmd/hive -count=1 -timeout 12mgo test -race ./pkg/dashboard ./cmd/hive -run 'TestIntegratedSetup|TestDashboardIntegratedSetup|TestDashboardSetupEnvironment' -count=1 -timeout 8mgit diff --checkThe broad Linux test attempt reached all affected packages green. Its remaining failures were unrelated existing/environment-owned checks: the inherited agent-state flake, credential-guard git ownership in a Windows bind mount, and generated-script tests in a bare Go image without Node. The broad Windows dashboard package also reproduced its existing Unix-mode assertion (
0666versus0600).