fix: preserve list markers on named slice types

[Harsh-128]

What happened

List markers on named slice types were not being picked up when the type was used as a struct field.

For example, when a field uses a named slice type:

type NamedItemList []string

with markers such as:

// +listType=map
// +listMapKey=port

the generated OpenAPI schema did not include the corresponding list extensions.

What changed

The generator now also checks the comments on the alias type when generating member extensions.

A regression test was added to TestExtensions covering a named slice type with +listType=map and +listMapKey=port.

Testing

• go test ./pkg/generators -run TestExtensions -count=1
• go test ./pkg/generators/...
• git diff --check

Fixes: #630

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Harsh-128 / name: Harsh-128 (1043415)

[kubernetes-prow]

Welcome @Harsh-128!

It looks like this is your first PR to kubernetes/kube-openapi 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-openapi has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Harsh-128
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Harsh-128]

Just following up on this PR when you get a chance. The fix addresses missing list markers for named slice types and includes a regression test.

Happy to make any changes based on review feedback. Thanks!

[Harsh-128]

Quick update: I’ve rechecked the changes and the regression test for named slice types. The PR is ready for review, and I’m happy to address any feedback. Thanks!