website: fix duplicated origin in generated sitemap URLs - #4456
website: fix duplicated origin in generated sitemap URLs#4456HarshPopat23 wants to merge 1 commit into
Conversation
Signed-off-by: HarshPopat23 <musichk61@gmail.com>
|
Hi @HarshPopat23. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
jaiakash
left a comment
There was a problem hiding this comment.
Thanks for this @HarshPopat23
/lgtm
What this PR does / why we need it:
Fixes #4455
The production sitemap at
https://www.kubeflow.org/sitemap.xmlcontained malformed URLs with a duplicated origin prefix (e.g.https://www.kubeflow.orghttps://www.kubeflow.org/...).This happened because
layouts/sitemap.xmlprependedhttps://www.kubeflow.orgto{{ .Permalink }}, even though Hugo already generates.Permalinkas an absolute URL based on--baseURLduring Netlify builds.This PR:
<loc>https://www.kubeflow.org{{ .Permalink }}</loc>with<loc>{{ .Permalink }}</loc>inlayouts/sitemap.xml.{{- if .Permalink }}check to prevent emitting empty<url>blocks.Which issue(s) this PR fixes:
Fixes #4455