Skip to content

Allow initializing w/ empty hostname (=local); remote paths with spaces; FAT hints - #40

Open
achadwick wants to merge 3 commits into
ku1ik:masterfrom
achadwick:master
Open

achadwick wants to merge 3 commits into
ku1ik:masterfrom
achadwick:master

Conversation

@achadwick

Copy link
Copy Markdown

A few minor fixes and user hints to make setup for syncing to transiently mounted USB devices with funny mountpoint names just a little smoother. FAT filesystems are pretty much a standard on these things; spaces in the names are common, and the things are almost always found locally attached. It's a use case which unison fails spectacularly badly at, to the extent of forcing a full comparison the first time on each new mount. rsync is dumber, so bitpocket seems to handle it better, given the right options.

achadwick added 3 commits May 8, 2013 16:29
Make the template a little clearer. SSH commands are for connecting to
remote hosts, not the remote hosts+path combination going by $REMOTE in the
main script.

Bitpocket is handy for syncing music players and flash sticks, so hint at
some good flags to use with FAT filesystems.
Allow $REMOTE_PATH to contain spaces (hosts too, I guess).

Make an error message quote $REMOTE too, for a little more clarity when
there are spaces in the path.
Allow init to be passed an empty hostname argument. The config file allows
it already, referring to local file access for the remote end.

Update usage instructions accordingly.
@runar0

runar0 commented May 8, 2013

Copy link
Copy Markdown
Contributor

I really like this one. As I merged it into my own fork I took the liberty of modifying the tests so they always use paths with spaces, under the assumption that a path without spaces will work if one with spaces did.

In the process a few problems with spaces within the tests themselves where uncovered and fixed. Feel free to merge the changes from my branch, patch-remote-path, into this pull request.

@greezybacon

Copy link
Copy Markdown
Collaborator

Just FYI- I added support for empty hostname (local syncs) in #66 and released it in v0.2

@greezybacon

Copy link
Copy Markdown
Collaborator

@achadwick @runar0 would it be acceptable to add the FAT hints as a wiki page here or as a commented-out line in the default configuration?

@achadwick

Copy link
Copy Markdown
Author

@greezybacon
It's been a while since I've played with bitpocket, but a commented-out line in the default config or template would work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants