This repository was archived by the owner on Oct 7, 2026. It is now read-only.
Repository navigation
feat: offer thumbnail regeneration after thumbnail size change - #127
Merged
Merged
Conversation
everpcpc
force-pushed
the
regenerate-thumbnails-on-size-change
branch
from
October 6, 2026 15:55
7f8658a to
99837d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changing the thumbnail size in
/admin/settingsused to be a no-op for already-imported books: existing thumbnails kept their old dimensions. After a successful settings save that includes athumbnailSizechange, a confirmation dialog now offers to regenerate book thumbnails — for all books, or only for books whose current thumbnail is smaller than the new size (for_bigger_result_only=true), or to skip. Regeneration goes throughPUT /api/v1/books/thumbnails, and the queued task shows up in the existing task queue panel.Closes #63
Changes
booksApi.regenerateThumbnails(forBiggerResultOnly)— wrapsPUT /api/v1/books/thumbnails?for_bigger_result_only=…(kmrs exposes PUT here, like komga; the issue text said POST).RegenerateThumbnailsDialogin the admin settings components, shown fromSettingsFormwhen a saved change set containsthumbnailSize.regenerate.*strings in theadmin-settingsnamespace for all ten locales.Validation
pnpm build(typecheck + bundle) andpnpm lintpass.