Repository navigation
fix(reader): contain YOLO translation bubbles within the bubble border - #1288
Merged
Merged
Conversation
Remove the bubble shape preference (ellipse/roundedRect) and always render rounded-rectangle backgrounds. For whole-bubble (YOLO) boxes the blob and its feather now stay inside the detected box so the bubble's own border line survives, the text area shrinks to a centered 0.5 of the box, and horizontal font fitting converges instead of overflowing the bubble edge.
Clamp the feather to half the box so the background survives on whole-bubble boxes whose short edge is under twice the feather floor; also fix an inverted subject in the conventions doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bubble shape preference added in #1286 did not work out in practice:
Fix
bubbleShapekey in stored preferences is ignored on decode, and its three localization keys (Bubble Shape / Ellipse / Rounded Rectangle) are removed.fitFontconverges like the vertical path (×0.85 steps down to the 8pt floor) instead of giving up and overflowing.Validation
make format,make build: iOS / macOS / tvOS all pass.make localizerun;./misc/translate.py listreports no missing translations.