Repository navigation
refactor(dashboard): refreshIfNeeded naming and view pass-through cleanup - #1101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up nits from the review of #1097. No behavior change.
What
DashboardPinnedSectionViewModel.refreshIfIdlerenamed torefreshIfNeeded: when a refresh is running for a different server the method cancels and restarts it, so "if idle" undersold the behavior.paginationinDashboardSectionView,pinnedCollections/pinnedReadListsinDashboardPinnedSectionView); the views readviewModel.*directly, per the no-computed-property-clutter convention.refreshIfNeeded(and the original PR description).Why
The AGENTS.md rule added in #1097 dropped the same-server qualifier the code actually implements; the rename and the pass-through removal keep the new row view-model seam consistent with repo conventions.
Validation
make formatclean;make buildpasses on iOS, macOS, and tvOS.