Repository navigation
Docking shell menu strings come from the app's Strings.axaml (#8) - #229
Merged
Merged
Conversation
Dock.Avalonia's user-facing strings (Float, Dock, Auto Hide, Close, the document/tool tab-strip menus, drag preview) are redefined under their own keys in Strings.axaml, which the app resolves before the Dock theme, so a UI translation overlay covers the docking shell too. A test loads Dock's ControlStrings.axaml and fails if an upgrade adds a key missing here. Developer-only RootDockDebug* strings are left to Dock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8.
Change
Dock.Avalonia.Themes.Fluent/Controls/ControlStrings.axaml, for exampleToolChromeControlAutoHideStringandDocumentTabStripItemCloseString.DialogEditor.Avalonia/Resources/Strings.axaml, with Dock's English defaults and_access keys. They cover drag preview, the document and tool tab-strip menus, tool chrome and pinned tools.Strings.axaml(Author a UI translation overlay (mechanism done, no content yet) #7) therefore translates the docking shell too.RootDockDebug*strings, which belong to Dock's developer debug picker that users never see. A comment inStrings.axamlsays so.Tests
DockStringsTests:ControlStrings.axamlat runtime and fails if any user-facing key is missing fromStrings.axaml, so a Dock upgrade that adds a menu string can't slip through untranslated;Full headless suite passes.
🤖 Generated with Claude Code