Repository navigation
Pin speaker header colours and Deadfire DisplayType values (#222) - #224
Merged
Merged
Conversation
The #82 review (27 Sep) saw every header in the bark colour because the Deadfire DisplayType was mapped off by one, so "Conversation" loaded as "Bark". #114 (28 Sep) fixed the map; loading companion_eder_hub from the game now gives the right DisplayType and header colours. These tests pin both: the enum values (fail against an off-by-one map) and each speaker category's header brush on the rendered card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #222.
Finding
#222 is already fixed, by #114.
DisplayTypewas mapped off by one, so everyConversationnode (value 1) loaded asBark.37f4e66, 28 Sep, "PoE2 DisplayType and Persistence use the game's enum values") corrected the map the next day.companion_eder_hubfrom the game install headlessly. All nodes haveDisplayTypeConversation(88 NPC, 18 player, 5 script, 1 narrator), and the rendered headers are crimson for NPCs and azure for the player.Tests (the issue's done-when)
Poe2EnumMapsTests: DeadfireDisplayTypevalues 0–3 map to Hidden, Conversation, Bark and Overlay, and the names map back. With the map shifted by one, 5 of 6 fail.CardHeader_UsesTheSpeakerCategorysBrush: NPC, player, narrator and script conversation nodes each render their ownBrush.Node.*.Header, and a bark renders the bark header.🤖 Generated with Claude Code