update: Global brand defaults page - #772
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughBranding documentation was rewritten with revised setup flows, asset constraints, visual customization guidance, logo fallback behavior, application logo linking, organization branding procedures, Management API operations, and instructions for removing Kinde branding. ChangesBrand documentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying kinde-docs-preview with
|
| Latest commit: |
aa174d0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e07aa452.kinde-docs-preview.pages.dev |
| Branch Preview URL: | https://tamal-update-global-brand-de.kinde-docs-preview.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/content/docs/design/brand/global-brand-defaults.mdx`:
- Around line 144-150: Update the default theme guidance to state that selecting
“User preference” requires configuring both light and dark brand color schemes,
while preserving the existing descriptions of the Light and Dark options.
- Around line 59-60: Update the supported file types entry in the global brand
defaults documentation to match the upload contract: remove WebP and AVIF, and
include GIF alongside SVG, PNG, and JPG.
- Around line 165-178: Update the “Global logo fallback” documentation so the
Disabled logo display order includes the global logo after the organization name
when no organization logo is available. Revise the accompanying explanation to
describe this final global-logo fallback while preserving the Enabled order and
setup steps.
- Around line 99-105: Update the Favicon section’s supported file type guidance
to distinguish SVG as the primary favicon from PNG as the supported fallback for
browsers such as Safari, while preserving the existing size and dimension
requirements.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 715baa49-7868-4bb5-aafe-bfdb8b4e7e0a
📒 Files selected for processing (1)
src/content/docs/design/brand/global-brand-defaults.mdx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/content/docs/design/brand/link-to-homepage.mdx`:
- Line 34: Update the sentence in the documentation content to hyphenate the
compound modifier as “Kinde-hosted authentication pages,” preserving the rest of
the sentence unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 57be20a4-be16-49d1-ae00-56aa40452483
📒 Files selected for processing (3)
src/content/docs/design/brand/apply-branding-for-an-organization.mdxsrc/content/docs/design/brand/link-to-homepage.mdxsrc/content/docs/design/brand/remove-kinde-branding.mdx
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/content/docs/design/brand/apply-branding-for-an-organization.mdx`:
- Line 41: Correct the subject–verb agreement in the branding documentation
sentence by changing “business offer” to “business offers,” while leaving the
rest of the sentence unchanged.
- Around line 109-115: Update the Favicon section’s supported file type guidance
to identify SVG as the primary format and PNG as the fallback for browsers such
as Safari. Include any distinct PNG limits if they differ; otherwise retain the
existing size and dimension requirements.
- Around line 83-87: Update the alt text on the comparison images in the
branding documentation to explicitly describe the default logo state and the
custom organization logo state, replacing the vague “org default register page”
and “after adding logo” descriptions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3e84975b-57a6-45d4-be02-f89fcd1bc4ef
📒 Files selected for processing (1)
src/content/docs/design/brand/apply-branding-for-an-organization.mdx
dtoxvanilla1991
left a comment
dtoxvanilla1991
left a comment
There was a problem hiding this comment.
Good work, 2 comments.
2 participants
This PR makes improvements to the global brand defaults setting page. It adds before-and-after screenshots and points to various other guides so clients can easily customize their Kinde experience for their users.
Summary by CodeRabbit