Skip to content

feat(ios): pass current display language to keyboard download - #16401

Merged
mcdurdin merged 1 commit into
masterfrom
feat/ios/15540-pass-display-language-to-download
Aug 20, 2026
Merged

feat(ios): pass current display language to keyboard download#16401
mcdurdin merged 1 commit into
masterfrom
feat/ios/15540-pass-display-language-to-download

Conversation

@mcdurdin

@mcdurdin mcdurdin commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Note that this information is also passed in via the HTTP Accept-Language header, but for now we are using the lang parameter to match implementation on all platforms. (We should consider moving to use Accept-Language in a future version for more transparent implementation).

Fixes: #15540

User Testing

  • TEST_IOS_SUPPORTED_LANGUAGE: Select a different preferred UI language (French, German, Spanish or Khmer) in iOS device settings. Verify that Keyman shows its UI in that language. Then verify that the Download Keyboard page in the app shows in that language also.
  • TEST_IOS_UNSUPPORTED_LANGUAGE: Select a different preferred UI language (e.g. Swedish) in iOS device settings. Verify that the Download Keyboard page in the app shows up in English.

@mcdurdin
feat(ios): pass current display language to keyboard download
5f7c979 
Note that this information is also passed in via the HTTP
`Accept-Language` header, but for now we are using the `lang` parameter
to match implementation on all platforms. (We should consider moving to
use `Accept-Language` in a future version for more transparent
implementation).

Fixes: #15540
@github-project-automation github-project-automation Bot moved this to Todo in Keyman Aug 19, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added the user-test-missing User tests have not yet been defined for the PR label Aug 19, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

User Test Results

Test specification and instructions

Test Artifacts

  • iOS
    • Keyman for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S36 milestone Aug 19, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Aug 19, 2026
@mcdurdin
mcdurdin requested a review from sgschantz August 19, 2026 08:27
mcdurdin
mcdurdin commented Aug 19, 2026
View reviewed changes
Comment thread ios/engine/KMEI/KeymanEngine/Classes/Resource Management/KeyboardSearchViewController.swift
baseURL.appendPathComponent("download-keyboards")

if #available(iOS 16.0, *) {
var langQueryItem = URLQueryItem(name:"lang", value:Bundle.main.preferredLocalizations[0])

@mcdurdin mcdurdin Aug 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quinn the Eskimo strikes again: https://stackoverflow.com/a/66551476/1836776

@sgschantz sgschantz Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also be linking to Quinn in an upcoming PR.

@Meng-Heng

Meng-Heng commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Test Specs

  1. Keyman for iPhone and iPad version 19.0.270-alpha-test16401
  2. iPad Air 1-inch (M3) iOS 26.2

Test Results

  • TEST_IOS_SUPPORTED_LANGUAGE (PASSED):
  1. On iPhone -> Settings -> Language & Region -> Set Khmer as the Primary language
  2. Launch Keyman
  3. VERIFIED:
    • The UIs are using Khmer language
    • The Download Keyboard page is in Khmer language.
  • TEST_IOS_UNSUPPORTED_LANGUAGE (PASSED):
  1. On iPhone -> Settings -> Language & Region -> Search for Swedish -> Set Svenska as the Primary language
  2. Launch Keyman
  3. VERIFIED:
    * The UIs are using Swedish language
    • The Download Keyboard page is in English language.

@keymanapp-test-bot keymanapp-test-bot Bot removed the user-test-required User tests have not been completed label Aug 19, 2026
sgschantz
sgschantz approved these changes Aug 19, 2026
View reviewed changes

@sgschantz sgschantz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcdurdin
mcdurdin merged commit d3ff993 into master Aug 20, 2026
8 checks passed
@mcdurdin
mcdurdin deleted the feat/ios/15540-pass-display-language-to-download branch August 20, 2026 05:54
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Aug 20, 2026
@keyman-server

keyman-server commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.271-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgschantz sgschantz sgschantz approved these changes

Assignees

No one assigned

Labels

feat has-user-test ios/engine/ ios/

Projects

Keyman
Status: Done

Milestone

A19S36

Development

Successfully merging this pull request may close these issues.

feat(ios): pass current display language to keyboard search

4 participants

@mcdurdin @Meng-Heng @keyman-server @sgschantz