Follow-up: support ignore_junk_filter in archive extraction and improve batch detection - #3265
Merged
Merged
Conversation
added 2 commits
September 30, 2026 12:46
…ove batch detection - Propagate ignore_junk_filter to _sf_children and demux_sflock to support archive extractions - Make @echo off detection case-insensitive in choose_package - Add batch and autoit to sandbox_packages in tasking - Add unit tests for junk filter and ignore_junk_filter in test_demux
…nored_with_option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up improvements to PR #3258 (
ignore_junk_filteroption):Support
ignore_junk_filterin Archive Extraction (_sf_children):ignore_junk_filterthroughdemux_sflock()into_sf_children().demux_extensions_list.Case-Insensitive
@echo offBatch Detection:analyzer/windows/lib/core/packages.py(choose_package()), made@echo offcheck case-insensitive (b"@echo off" in file_content.lower()) so polyglot scripts (such aspolyshell.txtusing@ECHO OFF) correctly resolve to thebatchpackage rather than falling back togeneric(which only opens Notepad on Windows).Register
batchandautoitinsandbox_packages:batchandautoitto thesandbox_packagestuple inlib/cuckoo/core/data/tasking.py.Unit Tests:
tests/test_demux.pycovering:ignore_junk_filter=0)ignore_junk_filter=1,true,yes)_sf_children()extraction behavior with and withoutignore_junk_filter.