Skip to content
This repository was archived by the owner on May 29, 2024. It is now read-only.

[WIP] tests: skip test_pytest_html if not installed#58

Open
blueyed wants to merge 3 commits into
kevlened:masterfrom
blueyed:opt-html
Open

[WIP] tests: skip test_pytest_html if not installed#58
blueyed wants to merge 3 commits into
kevlened:masterfrom
blueyed:opt-html

Conversation

@blueyed

@blueyed blueyed commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

This is for convenience, and it being tested on CI should be covered via
coverage etc.

This is for convenience, and it being tested on CI should be covered via
coverage etc.
@blueyed

blueyed commented Nov 22, 2019

Copy link
Copy Markdown
Contributor Author

I'd like to test here if not testing it would be reported, so please do not merge it yet.

@blueyed blueyed changed the title tests: skip test_pytest_html if not installed [WIP] tests: skip test_pytest_html if not installed Nov 22, 2019
@codecov-io

codecov-io commented Nov 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #58 into master will decrease coverage by 8.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #58     +/-   ##
=========================================
- Coverage   70.86%   62.56%   -8.3%     
=========================================
  Files           5        5             
  Lines         357      358      +1     
  Branches       35       35             
=========================================
- Hits          253      224     -29     
- Misses         93      122     +29     
- Partials       11       12      +1
Flag Coverage Δ
#linux 62.56% <100%> (-8.3%) ⬇️
#py36 62.56% <100%> (-8.3%) ⬇️
#py37 62.56% <100%> (-8.3%) ⬇️
Impacted Files Coverage Δ
tests/test_general.py 84% <100%> (-16%) ⬇️
pytest_parallel/__init__.py 52.89% <0%> (-6.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4a52d...460df7a. Read the comment docs.

@blueyed

blueyed commented Nov 22, 2019

Copy link
Copy Markdown
Contributor Author

offtopic: @codecov-io should not post comments.. we have .ci/codecov.yml to turn them off..

@blueyed

blueyed commented Nov 22, 2019

Copy link
Copy Markdown
Contributor Author

The comment reflects it:

  • Coverage 70.86% 62.56% -8.3%

But there's no status.

@kevlened
Do you have a global codecov config somewhere already by chance?

@kevlened

kevlened commented Jan 2, 2020

Copy link
Copy Markdown
Owner

There's no global codecov config. Incidentally, I made you a contributor to the project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants