fix: retry transient proxy restoration - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
PR #100 exposed one transient macOS helper failure (
EINVAL) in the owner disconnect restoration path, followed by a clean rerun. Review found that the session removed its watchdog handle before disarm completed, preventing a meaningful retry after any I/O error.Verification
cargo fmt --all -- --checkcargo test -p codeischeap-proxy-recovery --all-targetscargo clippy -p codeischeap-proxy-recovery --all-targets -- -D warningspython -m unittest discover -s scripts/tests -v(32 passed, 1 skipped because Windows symlink creation is unavailable)git diff --checkFull local workspace Rust verification is deferred to CI because this Windows environment lacks Perl required by the vendored OpenSSL build. The affected crate and its complete target set pass locally.