Skip to content

refactor: add local SCSS foundation for Bootstrap removal#4485

Open
elevatebart wants to merge 2 commits intomainfrom
feat/bootstrap-css-shimming
Open

refactor: add local SCSS foundation for Bootstrap removal#4485
elevatebart wants to merge 2 commits intomainfrom
feat/bootstrap-css-shimming

Conversation

@elevatebart
Copy link
Copy Markdown
Contributor

Summary

Establishes the local SCSS replacements that will coexist with Bootstrap during the incremental migration.

PR 1 — Local SCSS foundation

Adds local SCSS modules that replicate the Bootstrap features actually used in the codebase. These coexist with Bootstrap during migration (imported after Bootstrap in vendor.scss) and will replace it fully in the final PR.

New files:

  • src/assets/styles/_mixins.scss — Drop-in media-breakpoint-up/down/between replacements using the existing $grid-breakpoints map; all 116 call sites need zero changes
  • src/assets/styles/_reset.scss — Minimal cross-browser normalization (replaces Bootstrap reboot/root/type/images)
  • src/assets/styles/_grid.scss — Full container/row/col system with responsive variants at all 6 breakpoints
  • src/assets/styles/_buttons.scss — Base .btn, .btn-lg, .btn-sm
  • src/assets/styles/_forms.scss.form-control, .form-select, .form-group, .input-group, etc.
  • src/assets/styles/_card.scss.card and all card sub-components using CSS custom properties
  • src/assets/styles/_components.scss — Transitions, nav/navbar, dropdown, breadcrumb, pagination, badge, modal, and helper utilities

vendor.scss updated to import all local modules after the Bootstrap imports.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

@kestrabot kestrabot bot added this to Pull Requests Apr 4, 2026
@github-project-automation github-project-automation bot moved this to To review in Pull Requests Apr 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Visual Changes Detected

Make sure changes are expected and review the Playwright report for details.

Playwright report artifact: https://github.com/kestra-io/docs/actions/runs/24243559704/artifacts/6371174148

To accept the updated visuals, click Accept, select the PR branch, set update_snapshots=true, and run the workflow.

Accept

@github-actions
Copy link
Copy Markdown
Contributor

🔦 Lighthouse Benchmark

Last updated: 2026-04-10T12:55:42
Last commit: 603c931

Tested: https://ks-feat-bootstrap-css-shimming-docs.kestra-io.workers.dev on 2026-04-10 12:55 UTC
Compared against main baseline from 2026-04-10

Scores (0–100, higher is better)

Page Performance Accessibility Best Practices SEO
Home 55 79 59 92
Pricing 97 88 59 100
Enterprise 91 ▲ +7 78 59 100
Cloud 92 83 59 100
About Us 99 ▲ +4 87 59 100
Docs Landing 89 84 59 92
Contribute to Kestra (simple docs) 96 84 59 92
Flow (full featured docs) 89 86 59 92
Blog Index 65 ▼ -16 86 59 100
Blog Post (sample) 99 83 59 100
VS Page (sample) 94 88 59 100
Plugins Landing 91 77 59 92
Plugin Page (sample) 95 87 59 100
Plugin Debug Page (sample) 96 87 59 100
Plugin Debug Return Page (sample) 0 ▼ -94 87 0 ▼ -59 100
Blueprints Landing 89 77 56 ▼ -3 92
Blueprint Audit Logs CSV Export 67 ▲ +6 82 59 100

Core Web Vitals (lower is better)

Page LCP FCP TBT CLS Speed Index
Home 2.47 s ▲ 0.95 s ▲ 550 ms ▼ 0.000 3.48 s ▲
Pricing 1.09 s ▲ 0.57 s ▲ 86 ms ▼ 0.000 0.88 s ▲
Enterprise 1.81 s ▲ 0.88 s ▲ 54 ms ▼ 0.000 1.15 s ▲
Cloud 1.83 s 0.57 s ▲ 36 ms 0.000 0.88 s ▲
About Us 0.91 s ▲ 0.56 s ▲ 49 ms ▲ 0.000 0.90 s
Docs Landing 1.82 s ▼ 0.55 s ▲ 139 ms 0.000 1.18 s
Contribute to Kestra (simple docs) 1.01 s 0.55 s ▲ 141 ms ▼ 0.003 0.71 s ▲
Flow (full featured docs) 0.87 s ▲ 0.58 s ▲ 253 ms ▼ 0.000 1.03 s ▲
Blog Index 10.59 s ▼ 0.50 s ▲ 51 ms 0.001 16.10 s ▼
Blog Post (sample) 0.99 s ▲ 0.55 s ▲ 44 ms ▼ 0.000 0.79 s ▲
VS Page (sample) 1.58 s ▼ 0.58 s ▲ 63 ms ▼ 0.000 0.94 s ▲
Plugins Landing 1.00 s ▲ 0.55 s ▲ 116 ms ▼ 0.000 2.61 s ▼
Plugin Page (sample) 0.97 s ▲ 0.57 s ▲ 37 ms ▼ 0.051 1.93 s ▼
Plugin Debug Page (sample) 0.94 s ▲ 0.52 s ▲ 68 ms 0.001 1.87 s ▼
Plugin Debug Return Page (sample) 0.00 s ▲ 0.00 s ▲ 0 ms ▲ 0.000 ▲ 0.00 s ▲
Blueprints Landing 1.58 s 0.87 s ▼ 47 ms ▲ 0.000 2.17 s ▼
Blueprint Audit Logs CSV Export 1.17 s ▲ 0.67 s 156 ms 0.528 2.29 s ▼
Legend

▲ improved  ·  ▼ regressed  ·  (blank) no significant change
Score threshold: ±3 pts  ·  Metric threshold: ±10% of baseline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To review

Development

Successfully merging this pull request may close these issues.

1 participant