kernel-test: normalize traffic monitor log names before uploading - #504
Closed
vineetgarc wants to merge 1 commit into
Closed
kernel-test: normalize traffic monitor log names before uploading#504vineetgarc wants to merge 1 commit into
vineetgarc wants to merge 1 commit into
Conversation
The traffic monitor names its logs after the test and subtest, so they can contain characters that actions/upload-artifact rejects. A subtest called "INET4: bpf_timestamping" makes the upload fail as below (see [1]) Error: The path for one of the files in artifact is not valid: /packets-125-15-net_timestamping__INET4:_bpf_timestamping-net_timestamping_ns.log. Contains the following character: Colon : run-vmtest already renames these, but only after the VM exits, so a step timeout or a dead VM kills it before that point. The upload step runs with if: always() and then trips over the names that were left behind. Rename them in a step of its own, also guarded by if: always(), so it happens whatever the outcome of the test step. It is a no-op when the directory is absent, which is the case for every test that does not enable the traffic monitor, and re-running it is harmless. Link: https://github.com/kernel-patches/vmtest/actions/runs/30710914503/job/9139901138 [1] Signed-off-by: Vineet Gupta <vineet.gupta@linux.dev>
Closed
theihor
requested changes
Aug 11, 2026
Contributor
There was a problem hiding this comment.
This essentially copy-pastes a script from libbpf/ci/run-vmtest, which is an unnecessary duplication.
always() is the right thing to do, but I think the right spot for it is in run-vmtest/action.yml as a last step.
So basically we need factor out this normalization from run.sh into action.yml.
Author
|
This is superseded by libbpf/ci#231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The traffic monitor names its logs after the test and subtest, so they can contain characters that actions/upload-artifact rejects. A subtest called "INET4: bpf_timestamping" makes the upload fail as below (see [1])
Error: The path for one of the files in artifact is not valid:
/packets-125-15-net_timestamping__INET4:_bpf_timestamping-net_timestamping_ns.log.
Contains the following character: Colon :
run-vmtest already renames these, but only after the VM exits, so a step timeout or a dead VM kills it before that point. The upload step runs with if: always() and then trips over the names that were left behind.
Rename them in a step of its own, also guarded by if: always(), so it happens whatever the outcome of the test step. It is a no-op when the directory is absent, which is the case for every test that does not enable the traffic monitor, and re-running it is harmless.
Link: https://github.com/kernel-patches/vmtest/actions/runs/30710914503/job/9139901138 [1]