ci: Denylist libarena parallel tests on s390x - #501
Open
mrpre wants to merge 1 commit into
Open
Conversation
The libarena parallel selftests spawn several threads, each running one BPF syscall program, and rendezvous them with a spin barrier inside BPF: run_libarena_parallel_test:FAIL:parallel_test_bitmap unexpected error: -110 an emulated VM cannot provide the real concurrency these tests exist to exercise, so running them there produces noise rather than coverage. This is the same reasoning behind the arena_spin_lock and res_spin_lock_stress entries already in this list https://github.com/kernel-patches/bpf/actions/runs/30407571610/job/90439350390 https://github.com/kernel-patches/bpf/actions/runs/30407371815/job/90438295786 https://github.com/kernel-patches/bpf/actions/runs/30407309576/job/90438238976 https://github.com/kernel-patches/bpf/actions/runs/30407232425/job/90437839166 Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libarena parallel selftests spawn several threads, each running one
BPF syscall program, and rendezvous them with a spin barrier inside BPF:
run_libarena_parallel_test:FAIL:parallel_test_bitmap unexpected error: -110
The barrier cannot wait indefinitely - BPF loops must be bounded, and on
architectures with timed may_goto support the effective budget is a 250ms
wall clock deadline. That budget is wall clock, but what it is waiting for
is CPU work on a peer thread, and emulation stretches that work by orders
of magnitude while leaving the deadline unchanged. The barrier therefore
times out long before the peer gets to run.
Beyond the timeout, an emulated VM cannot provide the real concurrency
these tests exist to exercise, so running them there produces noise rather
than coverage. This is the same reasoning behind the arena_spin_lock and
res_spin_lock_stress entries already in this list.
Only the parallel subtests are denied. The serial libarena subtests keep
running and still cover the s390 JIT's atomic instruction generation
(bmp_test_and_set_bit() and friends compile down to cmpxchg on arena
memory), so no JIT coverage is lost.
https://github.com/kernel-patches/bpf/actions/runs/30407571610/job/90439350390
https://github.com/kernel-patches/bpf/actions/runs/30407371815/job/90438295786
https://github.com/kernel-patches/bpf/actions/runs/30407309576/job/90438238976
https://github.com/kernel-patches/bpf/actions/runs/30407232425/job/90437839166