Repository navigation
Send si=true when reading and updating an SSO integration - #99
Merged
Merged
Conversation
- GetSSOIntegration and UpdateSSOIntegration always send si=true; without it SendGrid omits completed_integration and it decodes as false
- GetSSOIntegrations now actually puts si in the query string
The SendGrid API reference describes the si query parameter as "If this
parameter is set to `true`, the response will include the
`completed_integration` field." It is defined for GET /v3/sso/integrations,
GET /v3/sso/integrations/{id} and PATCH /v3/sso/integrations/{id}.
- https://www.twilio.com/docs/sendgrid/api-reference/single-sign-on-settings/get-an-sso-integration
- https://github.com/twilio/sendgrid-oai/blob/8898f95ba784888ec9c29cfd6fab26806eed408c/spec/json/tsg_sso_v3.json#L414-L500
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kenzo0107
force-pushed
the
fix/sso-integration-si
branch
from
September 29, 2026 11:34
7511ad4 to
43a4675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /v3/sso/integrations/{id}andPATCH /v3/sso/integrations/{id}only includecompleted_integrationin the response when thesi=truequery parameter is set.GetSSOIntegration/UpdateSSOIntegrationnever sent it, soCompletedIntegrationalways decoded asfalse.falseends up in state and is sent back in the next PATCH, which resets the integration's completed flag (reported in fix: sso_integration Update reads unknown plan ID, causing resource not found terraform-provider-sendgrid#212).si=true. The method signatures stay the same.GetSSOIntegrationsbuilt thesiquery but never assigned it tou.RawQuery, soSi: truehad no effect. Fixed.References
The SendGrid API reference describes the
siquery parameter as:It is defined for
GET /v3/sso/integrations,GET /v3/sso/integrations/{id}andPATCH /v3/sso/integrations/{id}(not forPOST).tsg_sso_v3.json(L414-L500)Test plan
go test ./...(the newsiquery assertions fail without the fix and pass with it)go test ./internal/provider/passes when using this branch through areplacedirective🤖 Generated with Claude Code