Skip to content

fix: render entity links correctly with RTL text #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kellnerd merged 3 commits into from
Aug 30, 2026
Merged

fix: render entity links correctly with RTL text #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de9ca1b
fix: convert artist credit rows to flexboxes to handle rtl correctly
arsinclair Jun 24, 2026
1a16d20
fix: render entity links correctly with RTL text
arsinclair Aug 30, 2026
9ca7016
Merge branch 'main' into fix/rtl-text
arsinclair Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions server/components/AlternativeValues.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ export function setupAlternativeValues<Root>(providerMap: Record<ProviderName, R
{uniqueValues.map(
([value, providerNames]) => (
<li>
{display ? display(value) : value}
{providerNames.map((name) => <ProviderIcon providerName={name} stroke={1.25} key={name} />)}
<span class='alt-value'>
{display ? display(value) : value}
{providerNames.map((name) => <ProviderIcon providerName={name} stroke={1.25} key={name} />)}
</span>
</li>
),
)}
Expand Down
10 changes: 10 additions & 0 deletions server/static/harmony.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,11 @@ ul.alt-values {
list-style: square;
}

span.alt-value {
display: flex;
flex-direction: row;
}

span.label svg.icon,
ul.alt-values svg.icon {
height: 16px;
Expand Down Expand Up @@ -330,6 +335,11 @@ code.isrc > span:not(:last-child)::after {

/* LinkedEntity.tsx */

span.entity-links {
display: inline-flex;
flex-direction: row;
}

span.entity-links > a {
text-decoration-style: dotted;
color: inherit;
Expand Down
Loading